Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Markdown] [Web/HTML] Remove ID attributes from HTML input page #9124

Merged
merged 1 commit into from
Sep 21, 2021

Conversation

wbamberg
Copy link
Collaborator

Part of #8961.

This PR removes uses of the id attribute from the main HTML <input> page: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input.

Mostly this is removing IDs like htmlattrdefthing, which are only used as targets from the preceding section. I've replaced those links with attr-thing which you get from the {{htmlattrdef}} macro.

I also took out a spurious live sample, and corrected a heading ID that didn't match the derived heading ID and was being referenced by a live sample (and so would have been broken in Markdown).

I have not removed IDs from the big table of input types in https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#input_types, which uses them for live samples. I thought this table is quite nice and not worth trying to dismember at this point. It will stay in HTML anyway.

@wbamberg wbamberg requested a review from a team as a code owner September 21, 2021 03:02
@wbamberg wbamberg requested review from estelle and removed request for a team September 21, 2021 03:02
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/HTML/Element/input
Title: <input>: The Input (Form Input) element
on GitHub
Flaw count: 6

  • macros:
    • /en-US/docs/Web/API/HTMLInputElement/checkValidity does not exist
    • /en-US/docs/Web/API/HTMLInputElement/setCustomValidity does not exist
    • /en-US/docs/Web/API/ValidityState/valueMissing does not exist
    • /en-US/docs/Web/API/ValidityState/valueMissing does not exist
    • /en-US/docs/Web/API/ValidityState/valid does not exist
    • and 1 more flaws omitted

External URLs

URL: /en-US/docs/Web/HTML/Element/input
Title: <input>: The Input (Form Input) element
on GitHub

No new external URLs

@teoli2003 teoli2003 merged commit d154e50 into mdn:main Sep 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2022
@wbamberg wbamberg deleted the html-remove-id-attribute-input branch October 15, 2022 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants