Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add space before assignment operator in Working with objects js guide #9299

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Add space before assignment operator in Working with objects js guide #9299

merged 1 commit into from
Sep 27, 2021

Conversation

digi-booster
Copy link
Contributor

fix - #9290

Issue number that this PR fixes (if any). For example: 'Fixes #987654321'
#9290

What was wrong/why is this fix needed? (quick summary only)

Anything else that could help us review it

@digi-booster digi-booster requested a review from a team as a code owner September 27, 2021 16:00
@digi-booster digi-booster requested review from Rumyra and removed request for a team September 27, 2021 16:00
@github-actions github-actions bot added the Content:JS JavaScript docs label Sep 27, 2021
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/JavaScript/Guide/Working_with_Objects
Title: Working with objects
on GitHub
Flaw count: 2

  • broken_links:
    • No need for the pathname in anchor links if it's the same page
    • Can't resolve /en-US/docs/Web/JavaScript/New_in_JavaScript/ECMAScript_5_support_in_Mozilla

External URLs

URL: /en-US/docs/Web/JavaScript/Guide/Working_with_Objects
Title: Working with objects
on GitHub

No new external URLs

wbamberg
wbamberg approved these changes Sep 27, 2021
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @digi-booster !

@wbamberg wbamberg merged commit 6d4fbc7 into mdn:main Sep 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wbamberg wbamberg wbamberg approved these changes

@Rumyra Rumyra Awaiting requested review from Rumyra

Assignees
No one assigned
Labels
Content:JS JavaScript docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@digi-booster @wbamberg