Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove EffectTiming and KeyframeEffectOptions from MDN #9709

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Remove EffectTiming and KeyframeEffectOptions from MDN #9709

merged 1 commit into from
Oct 13, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes the documentation for the EffectTiming API to go along with its removal in BCD, see mdn/browser-compat-data#12765. Additionally, this PR cleans up the remnants of the KeyframeEffectOptions dictionary.

@queengooborg queengooborg requested a review from a team October 10, 2021 06:48
@queengooborg queengooborg requested review from a team as code owners October 10, 2021 06:48
@queengooborg queengooborg requested review from fiji-flo and sideshowbarker and removed request for a team October 10, 2021 06:48
@github-actions github-actions bot added Content:DevTools Firefox DevTools docs (retired) Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs labels Oct 10, 2021
@github-actions
Copy link
Contributor

Preview URLs

Flaws

Note! 8 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Tools/Page_Inspector/How_to/Work_with_animations
Title: Work with animations
on GitHub
Flaw count: 4

  • broken_links:
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • Can't resolve /en-US/docs/Mozilla/Firefox/Developer_Edition

URL: /en-US/docs/Web/API/Animation/currentTime
Title: Animation.currentTime
on GitHub
Flaw count: 1

  • broken_links:
    • Is currently http:// but can become https://

URL: /en-US/docs/Web/API/KeyframeEffect
Title: KeyframeEffect
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/KeyframeEffect/pseudoElement does not exist
  • broken_links:
    • Is currently http:// but can become https://
  • bad_bcd_links:
    • no explanation!

External URLs

URL: /en-US/docs/Tools/Page_Inspector/How_to/Work_with_animations
Title: Work with animations
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Animation/currentTime
Title: Animation.currentTime
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/KeyframeEffect
Title: KeyframeEffect
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/KeyframeEffect/KeyframeEffect
Title: KeyframeEffect()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Web_Animations_API
Title: Web Animations API
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Web_Animations_API/Using_the_Web_Animations_API
Title: Using the Web Animations API
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/AnimationEffect
Title: AnimationEffect
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/AnimationEffect/getComputedTiming
Title: AnimationEffect.getComputedTiming()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/AnimationEffect/updateTiming
Title: AnimationEffect.updateTiming()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/AnimationEffect/getTiming
Title: AnimationEffect.getTiming()
on GitHub

No new external URLs


URL: /en-US/docs/Web/API/Element/animate
Title: Element.animate()
on GitHub

No new external URLs

@sideshowbarker sideshowbarker merged commit b2e158f into mdn:main Oct 13, 2021
@queengooborg queengooborg deleted the EffectTiming branch October 13, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:DevTools Firefox DevTools docs (retired) Content:Other Any docs not covered by another "Content:" label Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants