Remove PaymentCurrencyAmount dictionary from MDN

[queengooborg]

This PR removes the documentation for the PaymentCurrencyAmount dictionary and folds its contents into the documentation for the PaymentItem dictionary. Correlates with its removal in BCD, see mdn/browser-compat-data#12794.

[github-actions]

Preview URLs

• https://pr9736.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/PaymentItem

Flaws

URL: /en-US/docs/Web/API/PaymentItem
Title: PaymentItem
on GitHub
Flaw count: 6

• macros:
  • /en-US/docs/Web/API/PaymentItem/amount does not exist
  • /en-US/docs/Web/API/PaymentItem/label does not exist
  • /en-US/docs/Web/API/PaymentItem/pending does not exist
• bad_bcd_links:
  • no explanation!
  • no explanation!
  • no explanation!

External URLs

URL: /en-US/docs/Web/API/PaymentItem
Title: PaymentItem
on GitHub

• https://www.iso.org/iso-4217-currency-codes.html (1 time) (Note! This may be a new URL 👀)

[hamishwillee]

Same question for this one. Great job on the dictionary inclusion, but can/should we retain any example code from the deleted docs?

[queengooborg]

I don't think it's particularly valuable (slight pun intended) to include either of the examples on the deleted docs. The description for the properties of the PaymentItem.amount object are pretty self-explanatory, I believe!

[hamishwillee]

Fair enough. This was just a prompt to ensure that you'd considered the examples, not that I thought they had to be copied :-)

[hamishwillee]

Thanks very much. Merging

[foolip]

I see a mix of terminology across PRs. I think "fields" here should be "properties".

[queengooborg]

Ah that's my bad -- would you be willing to send a PR to update the wording for consistency? I'll happily review and merge them right away!