-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Markdown][Add-ons] Make acknowledgements convertible as Markdown notes #9845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 tiny changes and we are good to go!
files/en-us/mozilla/add-ons/webextensions/api/permissions/request/index.html
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/api/tabs/onhighlightchanged/index.html
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/manifest.json/storage/index.html
Outdated
Show resolved
Hide resolved
…est/index.html Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…changed/index.html Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
…e/index.html Co-authored-by: Jean-Yves Perrier <jypenator@gmail.com>
Could we update this to make "Note:" prefix to the sentences starting "This API …". At least to my eye having something that looks like a title followed by a colon looks a bit odd. |
You mean instead of:
...have:
? |
@wbamberg That is my thinking |
Yeah, I think you are right. I'll get another PR up. |
Part of #9842.
In Markdown notes have to start with Note:. Many of the notes in the add-ons docs are to acknowledge that the APIs are derived from Chrome APIs, and use Acknowledgement instead. This PR changes those cases to use Note: instead.