-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebExtensions: Fix conflicting behavior explanation across browsers for "homepage_url" and "developer.url". #9950
Conversation
Fix conflicting behavior explanation across browsers for "homepage_url" and "developer.url".
Preview URLsFlawsNone! 🎉 External URLsURL: No new external URLs (this comment was updated 2021-10-24 15:51:20.612638) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggestion to tighten the wording
@@ -31,7 +31,7 @@ | |||
|
|||
<p>URL for the extension's home page.</p> | |||
|
|||
<p>If the <a href="/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer">developer</a> key is supplied and it contains the "url" property, this will override the homepage_url key.</p> | |||
<p>If both <a href="/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer">developer</a> key is supplied and it contains the "url" property and "homepage_url" is defined. Mozilla Firefox will favor "developer.url" while Opera favors "homepage_url".</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering whether "favor" is to open to interpretation:
<p>If a <a href="/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/developer">developer</a> key containing the "url" property and "homepage_url" are defined, Mozilla Firefox uses "developer.url" while Opera uses "homepage_url".</p>
And, are we covered for the behavior in Chrome?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google Chrome doesn't support the developer
property so no conflicts appear. As for the favor, we can specify it uses one over the other instead of favor. Tho both are true. If they use it they actually favor them as well. Happy with the edit you are proposing! Not sure what the behavior is on Apple Safari.
Relevant link:
w3c/webextensions#67
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlosjeurissen As we are preparing to convert to markdown I've gone ahead, made the changes and merged, many thanks for your help.
Clarifying "favor" and adding a note regarding Chrome and Safari
Fix conflicting behavior explanation across browsers for "homepage_url" and "developer.url".
Summary
Better explained the behavior of conflicting homepage_url with developer.url in manifest.json of webExtensions.
Motivation
Fix untrue statement about conflicting behavior in Opera.
Supporting details
The Opera behavior has been tested in the latest Opera Desktop version. While the behavior in Firefox has been taken from what was already mentioned in MDN.
This PR…