Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding houdini properties to inheritance data #303

Merged

Conversation

chrisdavidmills
Copy link
Contributor

As per #302

A couple of points — in the issue, CSSMathValue and CSSUnitValue are both listed in two places. I've not included the second instance, in both cases. @jpmedley , let me know if that's correct. Thanks!

@jpmedley
Copy link
Contributor

jpmedley commented Sep 28, 2018

Good catch! I've updated the ticket to indicate which of the duplicates are errors.

@chrisdavidmills
Copy link
Contributor Author

Thanks @jpmedley ; I've fixed the inheritance of CSSUnitValue.

@chrisdavidmills chrisdavidmills requested a review from ddbeck October 1, 2018 05:57
@Elchi3
Copy link
Member

Elchi3 commented Oct 1, 2018

Same here, the file that MDN uses, is actually https://github.com/mdn/kumascript/blob/master/macros/InterfaceData.json So, if you expect something on MDN (sidebars) to be changed, change it on KumaScript.

@chrisdavidmills
Copy link
Contributor Author

@Elchi3 I have opened a new PR to put this data in the right place: mdn/kumascript#907

Not sure if we want to add these in both places, or I can just close the old PRs now?

Copy link
Contributor

@ExE-Boss ExE-Boss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

Also, we probably want to add them to both repositories, given that the API sidebars will eventually be migrated to use this repository too (see #342).

@chrisdavidmills chrisdavidmills merged commit 8c21371 into mdn:master Jan 9, 2019
@chrisdavidmills
Copy link
Contributor Author

I'll merge this for now, just to clear it out of the queue if for no other reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants