Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial addition of function data #638

Merged
merged 7 commits into from
Feb 3, 2023
Merged

Initial addition of function data #638

merged 7 commits into from
Feb 3, 2023

Conversation

B-Teague
Copy link
Contributor

@B-Teague B-Teague commented Feb 3, 2023

Description

Adding mdn data for functions like rgb(), var(), etc.
Added status, groups, and mdn_url for functions.
Cloned syntax from syntaxes.json file.

Motivation

mdn data did not have status or mdn_url metadata about functions. For example, is target-counter() nonstandard now?

Additional details

I am writing CSS helper functions for CSS-in-JS libraries that are generated based on mdn data and syntax.
I want to provide links to mdn for function syntax and documentation and ignore deprecated nonstandard functions.

css([
   background(rgb(0,0,255)),
   minWidth(px(50)),
   minHeight(px(50))
])

Related issues and pull requests

Relates to #135

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

css/functions.json Outdated Show resolved Hide resolved
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

Note that, in the mid-term, we plan to retire this repo, though no concrete plans have been made yet.

@teoli2003 teoli2003 merged commit b8bef32 into mdn:main Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution.

@B-Teague B-Teague deleted the functions branch February 6, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants