Adding the data for the container* properties
#657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed the schema for the typo. There is more work to be done in it and in l10n.css; I plan to do this tomorrow. |
wbamberg
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
👍 thank you @yarusome and @teoli2003 . We really need a better way to do this.
Yes, but one improvement after the other. This one is not easy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the data for the
container,container-name, andcontainer-typeproperties. It also corrects the spelling for the "listEachItemIdentifyerOrNoneAuto" key.Motivation
Additional details
The spec links for these properties:
https://w3c.github.io/csswg-drafts/css-contain-3/#container-shorthand
https://w3c.github.io/csswg-drafts/css-contain-3/#container-name
https://w3c.github.io/csswg-drafts/css-contain-3/#container-type
CSSWG issue related to the computed value of
container-type:w3c/csswg-drafts#8643
Related issues and pull requests
Relates to mdn/content#24786.