Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CSS SVG d and fill-* properties #754

Merged
merged 8 commits into from
Aug 29, 2024
Merged

feat: add CSS SVG d and fill-* properties #754

merged 8 commits into from
Aug 29, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Aug 9, 2024

Description

add d, fill, fill-opacity, and fill-rule properties

Motivation

these reference pages are being added to MDN docs under CSS

Additional details

https://svgwg.org/svg2-draft/painting.html#FillProperties
https://svgwg.org/svg2-draft/paths.html#TheDProperty
also made alphabetical

Related issues and pull requests

Add missing CSS properties: mdn/content#34763
Fixes: openwebdocs/project#210
addresses: #750

@estelle estelle requested review from wbamberg and bsmth August 9, 2024 19:15
@estelle estelle changed the title feat: add CSS SVG fill properties feat: add CSS SVG d and fill-* properties Aug 20, 2024
"syntax": "none | <color> | <url> [none | <color>]? | context-fill | context-stroke",
"media": "visual",
"inherited": true,
"animationType": "byComputedValueType",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be listing:

the fill painting properties—fill-color, fill-image, fill-origin, fill-position, fill-size, and fill-repeat

Similar to https://github.com/mdn/data/pull/657/files?

Copy link
Member Author

@estelle estelle Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no.
` is defined as color and fallback, not background image.
https://svgwg.org/svg2-draft/painting.html#FillProperties is

origin, position, size, and repeat are not part of paint in any implementation

(this spec is from 2017 and seemingly abandoned. the above spec is the active one.)

"fill-opacity": {
"syntax": "<alpha-value>",
"media": "visual",
"inherited": false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this inherits: https://drafts.fxtf.org/fill-stroke-3/#fill-opacity or am I looking at the wrong place?

Copy link
Member Author

@estelle estelle Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch.
but https://svgwg.org/svg2-draft/painting.html#FillOpacity is the better spec.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, gotcha, this is confusing with the SVG/CSS crossover

@bsmth bsmth requested a review from a team as a code owner August 29, 2024 14:15
@bsmth bsmth requested review from pepelsbey and removed request for a team August 29, 2024 14:15
css/properties.json Outdated Show resolved Hide resolved
@estelle estelle requested a review from bsmth August 29, 2024 15:37
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Estelle, I think we're good to go!

@bsmth bsmth merged commit 7384073 into main Aug 29, 2024
3 checks passed
@bsmth bsmth deleted the fill2 branch August 29, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project: Add missing "widely available" CSS attributes
2 participants