-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CSS SVG d and fill-* properties #754
Conversation
"syntax": "none | <color> | <url> [none | <color>]? | context-fill | context-stroke", | ||
"media": "visual", | ||
"inherited": true, | ||
"animationType": "byComputedValueType", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be listing:
the fill painting properties—fill-color, fill-image, fill-origin, fill-position, fill-size, and fill-repeat
Similar to https://github.com/mdn/data/pull/657/files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no.
` is defined as color and fallback, not background image.
https://svgwg.org/svg2-draft/painting.html#FillProperties is
origin, position, size, and repeat are not part of paint in any implementation
(this spec is from 2017 and seemingly abandoned. the above spec is the active one.)
css/properties.json
Outdated
"fill-opacity": { | ||
"syntax": "<alpha-value>", | ||
"media": "visual", | ||
"inherited": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this inherits: https://drafts.fxtf.org/fill-stroke-3/#fill-opacity or am I looking at the wrong place?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch.
but https://svgwg.org/svg2-draft/painting.html#FillOpacity is the better spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, gotcha, this is confusing with the SVG/CSS crossover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Estelle, I think we're good to go!
Description
add
d
,fill
,fill-opacity
, andfill-rule
propertiesMotivation
these reference pages are being added to MDN docs under CSS
Additional details
https://svgwg.org/svg2-draft/painting.html#FillProperties
https://svgwg.org/svg2-draft/paths.html#TheDProperty
also made alphabetical
Related issues and pull requests
Add missing CSS properties: mdn/content#34763
Fixes: openwebdocs/project#210
addresses: #750