chore: update linear-gradient syntax to use optional color-interpolation-method #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayaKrishnaNamburu
requested review from
bsmth
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The syntax for
linear-gradientis missingcolor-interpolation-methodwhich had a baseline support from May 2023. You can get more details about the property herehttps://developer.mozilla.org/en-US/docs/Web/CSS/color-interpolation-method
It is even missing from the formal syntax of linear-gradient property page in mdn
Here is the CSS-Image-Module-4 with it's updated syntax for linear-gradients to support
color-interpolation-method.Motivation
When trying to pass
linear-gradientvalues using 3rd party property parsers likecss-tree. It property is failing it is reading from mdn which had outdated syntax for linear-gradient.Here is an example
https://stackblitz.com/edit/vitejs-vite-147ich?file=main.js
Additional details
CSS Image Module 4 -> https://drafts.csswg.org/css-images-4/#linear-gradients