-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update syntax for 'forced-color-adjust' & 'scale' properties, 'axis', 'color', 'scroller', 'system-color' types #771
Conversation
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
scroller()
type syntax.
scroller()
type syntax.aspect-ratio
property and scroller()
type syntax.
aspect-ratio
property and scroller()
type syntax.
Thank you! FYI, |
@bsmth Will this fix be released on v2.12.2? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, all! 👍🏻
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
Description
Currently all these cases return a mismatch:
aspect-ratio: auto 3/4;
animation-timeline: scroll(self);
,forced-color-adjust: preserve-parent-color;
.color: LinkText;
scale: 50%
They are all valid CSS properties/values according to https://developer.mozilla.org/en-US/docs/Web/CSS/aspect-ratio#syntax, https://developer.mozilla.org/en-US/docs/Web/CSS/animation-timeline#formal_syntax, https://developer.mozilla.org/en-US/docs/Web/CSS/system-color#syntax, and https://developer.mozilla.org/en-US/docs/Web/CSS/forced-color-adjust.
Motivation
Stylelint's rule declaration-property-value-no-unknown raises false positives. Demo
E.g.