Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css): Update <alpha-value> usage #784

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 18, 2024

Description

for css properties, <alpha-value> has been replaced with <opacity-value>

see w3c/csswg-drafts@d995b34 for opacity, rest seems to be so when added

opacity https://drafts.csswg.org/css-color/#transparency
fill-opacity https://drafts.fxtf.org/fill-stroke/#fill-opacity
shape-image-threshold https://drafts.csswg.org/css-shapes/#shape-image-threshold-property

also, for css functions, it still keep to use <alpha-value>

Motivation

Additional details

Related issues and pull requests

suggest: merge #786 first

@skyclouds2001 skyclouds2001 changed the title <alpha-value> rename to <opacity-value> <alpha-value> replace with <opacity-value> Nov 18, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 18, 2024 19:19
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner November 18, 2024 19:19
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team November 18, 2024 19:19
@skyclouds2001 skyclouds2001 changed the title <alpha-value> replace with <opacity-value> feat(css): <alpha-value> replace with <opacity-value> Nov 19, 2024
css/properties.json Outdated Show resolved Hide resolved
@skyclouds2001 skyclouds2001 changed the title feat(css): <alpha-value> replace with <opacity-value> feat(css): update <alpha-value> usage Nov 19, 2024
@skyclouds2001 skyclouds2001 changed the title feat(css): update <alpha-value> usage feat(css): Update <alpha-value> usage Nov 19, 2024
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@pepelsbey pepelsbey merged commit 87dc78b into mdn:main Dec 2, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the alpha-opacity-value branch December 2, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants