Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css): Add data for lighting-color, flood-color, flood-opacity #787

Merged
merged 8 commits into from
Dec 5, 2024
Merged

feat(css): Add data for lighting-color, flood-color, flood-opacity #787

merged 8 commits into from
Dec 5, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 19, 2024 •
edited
Loading

skyclouds2001
skyclouds2001 commented Nov 19, 2024
View reviewed changes
css/properties.json Outdated Show resolved Hide resolved
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 19, 2024 21:04
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner November 19, 2024 21:04
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team November 19, 2024 21:04
@skyclouds2001 skyclouds2001 mentioned this pull request Nov 19, 2024
Closed
7 tasks
@skyclouds2001 skyclouds2001 changed the title feat(css): Add data for lighting-color, flood-color, and flood-opacity feat(css): Add data for lighting-color, flood-color, flood-opacity Nov 19, 2024
@skyclouds2001 skyclouds2001 mentioned this pull request Nov 27, 2024
Open
98 tasks
pepelsbey
pepelsbey requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, but there are a bunch of lint issues that need to be fixed before the merge. I tried to fix a few, but it seems like it's not enough.

skyclouds2001
skyclouds2001 commented Dec 2, 2024
View reviewed changes
l10n/css.json Outdated Show resolved Hide resolved
skyclouds2001
skyclouds2001 commented Dec 2, 2024
View reviewed changes
l10n/css.json Outdated Show resolved Hide resolved
skyclouds2001
skyclouds2001 commented Dec 2, 2024
View reviewed changes
l10n/css.json Outdated Show resolved Hide resolved
skyclouds2001
skyclouds2001 commented Dec 2, 2024
View reviewed changes
l10n/css.json Outdated Show resolved Hide resolved
skyclouds2001
skyclouds2001 commented Dec 2, 2024
View reviewed changes
l10n/css.json Outdated Show resolved Hide resolved
pepelsbey
pepelsbey approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@pepelsbey pepelsbey merged commit 2e42c31 into mdn:main Dec 5, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Merged
@skyclouds2001 skyclouds2001 deleted the flood-lighting branch December 5, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey pepelsbey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing CSS properties defined in SVG
2 participants
@skyclouds2001 @pepelsbey