fix(hsts): resolve path for hsts-preload.json file
#41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct. |
argl
approved these changes
Jul 23, 2024
|
Congratulations on your first merged pull request. 🎉 Thank you for your contribution! Did you know we have a project board with high-impact contribution opportunities? We look forward to your next contribution. |
caugner
changed the title
hsts-preload.json filehsts-preload.json file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change correctly resolves the relative path for
fs.readFileSync()which gets the contents of thehsts-preload.jsonfile.Motivation
I'm importing this library into an existing Node application. But when I run the main
scan()function, thehsts()function fails to read thehsts-preload.jsonfile due to the path resolving relative to the Node process. By utilising theimport.metaobject it is possible to read the file correctly.BEGIN_COMMIT_OVERRIDE
fix(hsts): resolve path for hsts-preload.json file
END_COMMIT_OVERRIDE