Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(svelt): Translation of 'svelte todo list beginning' #11738

Merged
merged 3 commits into from
Mar 17, 2023
Merged

docs(svelt): Translation of 'svelte todo list beginning' #11738

merged 3 commits into from
Mar 17, 2023

Conversation

thewoowon
Copy link
Contributor

Description

Translation of 'svelte todo list beginning'

Motivation

open source contribution

Additional details

lint tested

Related issues and pull requests

Relates to #11429

@thewoowon thewoowon requested a review from a team as a code owner February 18, 2023 13:39
@thewoowon thewoowon requested review from pje1740 and removed request for a team February 18, 2023 13:39
@github-actions github-actions bot added the l10n-ko Issues related to Korean content. label Feb 18, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 18, 2023

Preview URLs

Flaws (112)

URL: /ko/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_Todo_list_beginning
Title: Svelte 할 일 목록 앱 시작
Flaw count: 112

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/HTML/Tables/Basics does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Basics
    • and 107 more flaws omitted
External URLs (5)

URL: /ko/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Svelte_Todo_list_beginning
Title: Svelte 할 일 목록 앱 시작

(comment last updated: 2023-03-12 08:02:54)

@SnowMarble
Copy link
Contributor

SnowMarble commented Feb 19, 2023

안녕하세요, 이번에 Learn 페이지의 "in this module" 섹션을 모두 제거하기로 했습니다. (#11694)
그리고 또 새롭게 추가된 메타데이터 sourceCommit도 한번 확인부탁드립니다:)👍

@thewoowon
Copy link
Contributor Author

"in this module" 섹션을 모두 삭제했습니다. 그런데 sourceCommit 관련해서는 참고만 하면 될까요?
그리고 제가 번역한 "svelte getting started" 장에서 이미지의 참조 주소가 en-US/~로 되어 있어 이미지가 보이지 않고 있습니다.
이미지를 제가 직접적으로 추가했을 때, 담당자분께서 이미지는 자동으로 참조하기 때문에 따로 폴더에 넣지 말라고 하셔서 삭제한 기억이 있습니다.
그것이 아니라면 폴더에 포함해야 할 것 같은데 무엇이 옳은 것인가요?

@SnowMarble
Copy link
Contributor

프리뷰 페이지는 변경된 파일에만 랜더링하기때문에 머지후 페이지가 반영되면 사진은 잘 불러올 수 있을겁니다.

sourceCommit은 추가해주셔야하는데, 여기서 번역한 파일 커밋 40자를 모두 복사해서 써주시면됩니다.🐱

l10n:
  sourceCommit: <hash>

@thewoowon
Copy link
Contributor Author

'in this module' 부분 삭제하고
sourceCommit의 hash는 '4a5ceb89ac004d087669aeee3c26475c2207787f'로 추가했습니다.
lint:md 확인 완료했습니다.

@hochan222
Copy link
Member

cc. @pje1740

Copy link
Collaborator

@pje1740 pje1740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

긴 문서 작업 고생 많으셨습니다! 확인이 늦었는데 번역 관련 코멘트가 많아진 점 양해 부탁 드리며 보시고 다른 의견 있으시면 편하게 말씀 주세요!

Copy link
Collaborator

@pje1740 pje1740 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정 요청 사항 반영하시느라 고생 많으셨습니다!

@pje1740 pje1740 merged commit 5f7f1ba into mdn:main Mar 17, 2023
JasonLamv-t pushed a commit to JasonLamv-t/translated-content that referenced this pull request Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-ko Issues related to Korean content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants