-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ko: Replaced {{HTMLRefTable}}
with markdown table
#12017
Conversation
Preview URLs Flaws (50)URL:
External URLs (1)URL:
(comment last updated: 2023-03-11 05:02:23) |
{{HTMLRefTable}}
with a summary of each tag{{HTMLRefTable}}
with markdown table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manjuu-eater Thank you so much for your contribution. There are a few things to fix, so I only went through half of it first. I will merge the reviews about the translation.
I couldn't add the metadata below, so I'd appreciate it if you could add it! (https://github.com/mdn/translated-content/blob/main/docs/ko/guides/meta-data-guide.md#%ED%8E%98%EC%9D%B4%EC%A7%80-%EA%B0%B1%EC%8B%A0-%ED%91%9C%EC%8B%9C)
---
title: HTML 요소 참고서
slug: Web/HTML/Element
+ l10n:
+ sourceCommit: 65e5a105aa794caa7d339b49951cbaa4a0b83dd3
---
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally, I was planning to update the whole thing, but... I think it would be better to write the meta tag next. It seems like this is enough.
update contents
Have a nice day :) |
Thank you for reviewing & editing! I did not know what sourceCommit meta tag means. (There is no Japanese version of translation documentation...) I made PR which adds sourceCommit to front-matter: #12222 |
Description
The
{{HTMLRefTable}}
macro became obsolete, and the entire table content was gone. So, I converted the macros as described below:(specifically, the first line that is not a front-matter, heading, or Lv1 list)
{{HTMLRefTable}}
did not seem to have this process)I am not entirely sure what the
{{HTMLRefTable}}
macro was actually doing.I assumed it probably did something like the above.
A PR in the Japanese version (#11993) was determined that there was no problem.
I can't understand what the translated text means.
So, I would like the reviewer to do the following tasks:
I am writing this English text with using a translator. Sorry if there are parts that are difficult to read.
Thank you in advance.
Motivation
Additional details
WayBackMachine page: http://web.archive.org/web/20221215193922/https://developer.mozilla.org/ko/docs/Web/HTML/Element
current page: https://developer.mozilla.org/ko/docs/Web/HTML/Element
Related issues and pull requests
Relates to #11953