Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-CN: Replaced {{HTMLRefTable}} with markdown table #12020

Merged
merged 3 commits into from
Mar 11, 2023

Conversation

manjuu-eater
Copy link
Contributor

Description

The {{HTMLRefTable}} macro became obsolete, and the entire table content was gone. So, I converted the macros as described below:

  1. Get the markdown corresponding to the "Element" cell of each table from the English version
  2. Set the markdowns to the "Element" cells in the translated version
  3. For each element (=HTML tag), get the first line of the translated version of the page
    (specifically, the first line that is not a front-matter, heading, or Lv1 list)
  4. Set the retrieved line to the "Description" cell
  5. If "Description" cell was empty, fill with en-US description ({{HTMLRefTable}} did not seem to have this process)

I am not entirely sure what the {{HTMLRefTable}} macro was actually doing.
I assumed it probably did something like the above.
A PR in the Japanese version (#11993) was determined that there was no problem.

I can't understand what the translated text means.
So, I would like the reviewer to do the following tasks:

  1. Since I did the conversion semi-mechanically, there may be some strange things in the text. Please check it lightly.
  2. Please compare with WayBackMachine page and check if there are any significant changes.

I am writing this English text with using a translator. Sorry if there are parts that are difficult to read.

Thank you in advance.

Motivation

Additional details

WayBackMachine page: http://web.archive.org/web/20221209203824/https://developer.mozilla.org/zh-CN/docs/Web/HTML/Element
current page: https://developer.mozilla.org/zh-CN/docs/Web/HTML/Element

Related issues and pull requests

Relates to #11953

@manjuu-eater manjuu-eater requested a review from a team as a code owner March 4, 2023 22:55
@manjuu-eater manjuu-eater requested review from irvin and removed request for a team March 4, 2023 22:55
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Mar 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2023

Preview URLs

Flaws (16)

URL: /zh-CN/docs/Web/HTML/Element
Title: HTML 元素参考
Flaw count: 16

  • macros:
    • /zh-CN/docs/Web/HTML/Attributes/accept does not exist but fell back to /en-US/docs/Web/HTML/Attributes/accept
    • /zh-CN/docs/Web/HTML/Attributes/capture does not exist but fell back to /en-US/docs/Web/HTML/Attributes/capture
    • /zh-CN/docs/Web/HTML/Attributes/elementtiming does not exist but fell back to /en-US/docs/Web/HTML/Attributes/elementtiming
    • /zh-CN/docs/Web/HTML/Attributes/for does not exist but fell back to /en-US/docs/Web/HTML/Attributes/for
    • /zh-CN/docs/Web/HTML/Attributes/max does not exist but fell back to /en-US/docs/Web/HTML/Attributes/max
    • and 10 more flaws omitted
  • translation_differences:
    • Differences in the important macros (0 in common of 2 possible)
External URLs (1)

URL: /zh-CN/docs/Web/HTML/Element
Title: HTML 元素参考

(comment last updated: 2023-03-11 07:11:47)

@manjuu-eater manjuu-eater changed the title zh-CH: Replaced {{HTMLRefTable}} with markdown table zh-CN: Replaced {{HTMLRefTable}} with markdown table Mar 4, 2023
@yin1999 yin1999 requested review from yin1999 and removed request for irvin March 5, 2023 02:23
@yin1999 yin1999 self-assigned this Mar 5, 2023
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I've modified some error in this PR:

  • replace the note card if it's the first paragraph
  • translate from the en-US content as many zh-CN documents are too old

@yin1999 yin1999 merged commit bdacce1 into mdn:main Mar 11, 2023
@manjuu-eater manjuu-eater deleted the htmlreftable-zh-cn branch March 16, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants