Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove at-rule @viewport links #14159

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Remove at-rule @viewport links #14159

merged 2 commits into from
Jul 17, 2023

Conversation

mems
Copy link
Contributor

@mems mems commented Jul 12, 2023

Description

Remove all links related to the at-rule @Viewport.

Motivation

All this links point to docs/Web/CSS/@Viewport page are already redirected to docs/Web/CSS.
Links are already removed in original content.

Additional details

w3c/csswg-drafts#7670

Related issues and pull requests

N/A

@mems mems requested review from a team as code owners July 12, 2023 09:52
@mems mems requested review from davbrito, sashasushko, hochan222, mfuji09, cw118 and nathipg and removed request for a team July 12, 2023 09:52
@github-actions github-actions bot added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels Jul 12, 2023
@mems
Copy link
Contributor Author

mems commented Jul 12, 2023

See also mdn/data#677

@mems
Copy link
Contributor Author

mems commented Jul 12, 2023

There is also the file files/ru/conflicting/web/css/index.md which is the content of @Viewport at-rule marked as "conflicted".

Copy link
Member

@sashasushko sashasushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥 Approve for ru. Thanks

@sashasushko
Copy link
Member

I will figure out with conflicted one, thanks

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

Preview URLs (23 pages)
Flaws (736)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /es/docs/Learn/CSS/CSS_layout/Responsive_Design
Title: Diseño receptivo
Flaw count: 108

  • macros:
    • /es/docs/Learn/CSS/Building_blocks/Cascade_layers does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Cascade_layers
    • /es/docs/Learn/CSS/Building_blocks/Organizing does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Organizing
    • /es/docs/Learn/CSS/Building_blocks/Creating_fancy_letterheaded_paper does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Creating_fancy_letterheaded_paper
    • /es/docs/Learn/CSS/Building_blocks/A_cool_looking_box does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/A_cool_looking_box
    • /es/docs/Learn/CSS/Styling_text/Typesetting_a_homepage does not exist but fell back to /en-US/docs/Learn/CSS/Styling_text/Typesetting_a_homepage
    • and 95 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /es/docs/Tools/Responsive_Design_View
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Can't resolve /es/docs/Web/CSS/Media_Queries
    • and 3 more flaws omitted

URL: /es/docs/Web/CSS/zoom
Title: zoom
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (4 in common of 5 possible)

URL: /es/docs/Web/CSS/At-rule
Title: Regla-At
Flaw count: 11

  • macros:
    • /es/docs/Web/CSS/@document does not exist but fell back to /en-US/docs/Web/CSS/@document
    • /es/docs/Web/CSS/@document does not exist but fell back to /en-US/docs/Web/CSS/@document
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Is currently http:// but can become https://
    • Link points to the page it's already on
    • Can't resolve /es/docs/Web/CSS/inheritance
    • and 4 more flaws omitted

URL: /fr/docs/Learn/CSS/CSS_layout/Responsive_Design
Title: Responsive design
Flaw count: 76

  • macros:
    • /fr/docs/Learn/CSS/Building_blocks/Cascade_layers does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Cascade_layers
    • /fr/docs/Learn/CSS/Building_blocks/Images_media_form_elements does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Images_media_form_elements
    • /fr/docs/Learn/CSS/Building_blocks/Organizing does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Organizing
    • /fr/docs/Learn/JavaScript/Asynchronous/Implementing_a_promise-based_API does not exist but fell back to /en-US/docs/Learn/JavaScript/Asynchronous/Implementing_a_promise-based_API
    • /fr/docs/Learn/JavaScript/Asynchronous/Sequencing_animations does not exist but fell back to /en-US/docs/Learn/JavaScript/Asynchronous/Sequencing_animations
    • and 63 more flaws omitted
  • broken_links:
    • Can't resolve /fr/docs/Outils/Vue_adaptative
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Can't resolve /fr/docs/Web/CSS/Media_Queries
    • Can't resolve /fr/docs/Web/CSS/Media_Queries
    • and 3 more flaws omitted

URL: /fr/docs/Web/CSS/Viewport_concepts
Title: Concepts relatifs au viewport
Flaw count: 5

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /fr/docs/Mozilla/Mobile/Balise_meta_viewport#Un_pixel_n'est_pas_un_pixel
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can't resolve /fr/docs/Mozilla/Mobile/Balise_meta_viewport

URL: /fr/docs/Web/CSS/zoom
Title: zoom
Flaw count: 3

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /fr/docs/Web/CSS/CSS_Transforms/Using_CSS_transforms
  • translation_differences:
    • Differences in the important macros (2 in common of 6 possible)

URL: /fr/docs/Web/CSS/env
Title: env()
Flaw count: 5

  • macros:
    • wrong xref macro used (consider changing which macro you use)
  • broken_links:
    • Can't resolve /fr/docs/Web/CSS/var()
    • Can't resolve /fr/docs/Web/CSS/CSS_Variables
    • Can't resolve /fr/docs/Web/CSS/Les_variables_CSS
  • translation_differences:
    • Differences in the important macros (4 in common of 7 possible)

URL: /fr/docs/Web/CSS/At-rule
Title: Règles @
Flaw count: 5

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • `/home/runner/work/translated-content/translated-content/mdn/content/node_modules/@mdn/yari/kumascript/macros/Compat.ejs:1

1| <%
2| /*
3|
4| Retrieves MDN compat data for a given feature

No first query argument or 'browser-compat' front-matter value passed`

  • broken_links:
    • Can't resolve /fr/Apprendre/CSS/Introduction_à_CSS/La_syntaxe#Les_instructions_CSS
    • Can't resolve /fr/Apprendre/CSS/Introduction_à_CSS/La_syntaxe#Les_blocs_CSS
  • translation_differences:
    • Differences in the important macros (2 in common of 3 possible)

URL: /ru/docs/Learn/CSS/CSS_layout/Responsive_Design
Title: Отзывчивый дизайн
Flaw count: 88

  • macros:
    • /ru/docs/Learn/CSS/Building_blocks/Cascade_layers does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Cascade_layers
    • /ru/docs/Learn/CSS/Building_blocks/Creating_fancy_letterheaded_paper does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/Creating_fancy_letterheaded_paper
    • /ru/docs/Learn/CSS/Building_blocks/A_cool_looking_box does not exist but fell back to /en-US/docs/Learn/CSS/Building_blocks/A_cool_looking_box
    • /ru/docs/Learn/CSS/CSS_layout/Media_queries does not exist but fell back to /en-US/docs/Learn/CSS/CSS_layout/Media_queries
    • /ru/docs/Learn/CSS/CSS_layout/Legacy_Layout_Methods does not exist but fell back to /en-US/docs/Learn/CSS/CSS_layout/Legacy_Layout_Methods
    • and 70 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ru/docs/Learn/CSS/Introduction_to_CSS
    • Can't resolve /ru/docs/Tools/Responsive_Design_Mode
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • and 8 more flaws omitted

URL: /ru/docs/Web/CSS/At-rule
Title: At-rules
Flaw count: 17

  • macros:
    • /ru/docs/Web/CSS/@charset does not exist but fell back to /en-US/docs/Web/CSS/@charset
    • /ru/docs/Web/CSS/@import does not exist but fell back to /en-US/docs/Web/CSS/@import
    • /ru/docs/Web/CSS/@keyframes does not exist but fell back to /en-US/docs/Web/CSS/@keyframes
    • /ru/docs/Web/CSS/font-option-alternates does not exist
    • This macro has been deprecated, and should be removed.
    • and 3 more flaws omitted
  • broken_links:
    • Can't resolve /ru/docs/Web/CSS/Синтаксис#CSS_statements
    • Can't resolve /ru/docs/Web/CSS/Синтаксис#Блоки_объявлений_CSS
    • Is currently http:// but can become https://
    • Link points to the page it's already on
    • Can't resolve /ru/docs/Web/CSS/inheritance
    • and 3 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 2 possible)

URL: /ru/docs/Web/HTML/Element/meta
Title: <meta> - элемент для описания метаданных
Flaw count: 57

  • macros:
    • /ru/docs/Web/HTML/Attributes/accept does not exist but fell back to /en-US/docs/Web/HTML/Attributes/accept
    • /ru/docs/Web/HTML/Attributes/autocomplete does not exist but fell back to /en-US/docs/Web/HTML/Attributes/autocomplete
    • /ru/docs/Web/HTML/Attributes/capture does not exist but fell back to /en-US/docs/Web/HTML/Attributes/capture
    • /ru/docs/Web/HTML/Attributes/disabled does not exist but fell back to /en-US/docs/Web/HTML/Attributes/disabled
    • /ru/docs/Web/HTML/Attributes/elementtiming does not exist but fell back to /en-US/docs/Web/HTML/Attributes/elementtiming
    • and 21 more flaws omitted
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • and 26 more flaws omitted

URL: /ja/docs/Web/CSS/Viewport_concepts
Title: ビューポートの概念
Flaw count: 4

  • broken_links:
    • Can't resolve /ja/docs/Mozilla/Mobile/Viewport_meta_tag#A_pixel_is_not_a_pixel
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can't resolve /ja/docs/Mobile/Viewport_meta_tag

URL: /ja/docs/Web/CSS/zoom
Title: zoom
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (4 in common of 5 possible)

URL: /ja/docs/Web/CSS/env
Title: env()
Flaw count: 3

  • macros:
    • /ja/docs/Web/CSS/var() redirects to /ja/docs/Web/CSS/var
    • /ja/docs/Web/CSS/var() redirects to /ja/docs/Web/CSS/var
  • broken_links:
    • Can't resolve /ja/docs/Web/CSS/CSS_Variables

URL: /ja/docs/Web/CSS/At-rule
Title: アットルール
Flaw count: 3

  • broken_links:
    • Can't resolve /ja/docs/Web/CSS/inheritance
    • Can't resolve /ja/docs/Web/CSS/CSS_Box_Model/Introduction_to_the_CSS_box_model
    • Can't resolve /ja/docs/Web/CSS/CSS_Box_Model/Mastering_margin_collapsing

URL: /ja/docs/Web/HTML/Element/meta/name
Title: 標準メタデータ名
Flaw count: 2

  • broken_links:
    • Can't resolve /ja/docs/Mobile/Viewport_meta_tag
    • Anchor not lowercase

URL: /pt-BR/docs/Learn/CSS/CSS_layout/Responsive_Design
Title: Design Responsivo
Flaw count: 130

  • macros:
    • /pt-BR/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter
    • /pt-BR/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /pt-BR/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /pt-BR/docs/Learn/HTML/Tables/Advanced does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Advanced
    • /pt-BR/docs/Learn/HTML/Tables/Structuring_planet_data does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Structuring_planet_data
    • and 116 more flaws omitted
  • broken_links:
    • Can't resolve /pt-BR/docs/Tools/Responsive_Design_Mode
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Can't resolve /pt-BR/docs/Web/CSS/Media_Queries
    • Can't resolve /pt-BR/docs/Web/CSS/Media_Queries
    • and 4 more flaws omitted

URL: /pt-BR/docs/Web/CSS/env
Title: env()
Flaw count: 7

  • macros:
    • This macro has been deprecated, and should be removed.
    • This macro has been deprecated, and should be removed.
    • Calling the Compat macro with any arguments is deprecated; instead use the 'browser-compat' front-matter key.
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can't resolve /pt-BR/docs/Web/CSS/Using_CSS_variables
  • translation_differences:
    • Differences in the important macros (2 in common of 8 possible)

URL: /pt-BR/docs/Web/HTML/Element/meta
Title: <meta>
Flaw count: 65

  • macros:
    • /pt-BR/docs/Web/HTML/Attributes/accept does not exist but fell back to /en-US/docs/Web/HTML/Attributes/accept
    • /pt-BR/docs/Web/HTML/Attributes/autocomplete does not exist but fell back to /en-US/docs/Web/HTML/Attributes/autocomplete
    • /pt-BR/docs/Web/HTML/Attributes/capture does not exist but fell back to /en-US/docs/Web/HTML/Attributes/capture
    • /pt-BR/docs/Web/HTML/Attributes/crossorigin does not exist but fell back to /en-US/docs/Web/HTML/Attributes/crossorigin
    • /pt-BR/docs/Web/HTML/Attributes/disabled does not exist but fell back to /en-US/docs/Web/HTML/Attributes/disabled
    • and 31 more flaws omitted
  • broken_links:
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • No need for the pathname in anchor links if it's the same page
    • and 23 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 4 possible)

URL: /ko/docs/Learn/CSS/CSS_layout/Responsive_Design
Title: 반응형 디자인
Flaw count: 114

  • macros:
    • /ko/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Video_and_audio_content
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web
    • /ko/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Mozilla_splash_page
    • /ko/docs/Learn/HTML/Tables/Basics does not exist but fell back to /en-US/docs/Learn/HTML/Tables/Basics
    • and 104 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://
    • Can't resolve /ko/docs/Web/CSS/Media_Queries
    • Can't resolve /ko/docs/Web/CSS/Media_Queries

URL: /ko/docs/Web/CSS/At-rule
Title: @-규칙
Flaw count: 8

  • macros:
    • /ko/docs/Web/CSS/@document does not exist but fell back to /en-US/docs/Web/CSS/@document
    • /ko/docs/Web/CSS/@counter-style does not exist but fell back to /en-US/docs/Web/CSS/@counter-style
    • /ko/docs/Web/CSS/@font-feature-values does not exist but fell back to /en-US/docs/Web/CSS/@font-feature-values
    • /ko/docs/Web/CSS/font-variant-alternates does not exist but fell back to /en-US/docs/Web/CSS/font-variant-alternates
    • /ko/docs/Web/CSS/@document does not exist but fell back to /en-US/docs/Web/CSS/@document
  • broken_links:
    • Anchor not lowercase
    • Anchor not lowercase
    • Is currently http:// but can become https://

URL: /ko/docs/Web/HTML/Element/meta/name
Title: 표준 메타데이터 이름
Flaw count: 23

  • macros:
    • /ko/docs/Web/HTML/Attributes/accept does not exist but fell back to /en-US/docs/Web/HTML/Attributes/accept
    • /ko/docs/Web/HTML/Attributes/capture does not exist but fell back to /en-US/docs/Web/HTML/Attributes/capture
    • /ko/docs/Web/HTML/Attributes/disabled does not exist but fell back to /en-US/docs/Web/HTML/Attributes/disabled
    • /ko/docs/Web/HTML/Attributes/elementtiming does not exist but fell back to /en-US/docs/Web/HTML/Attributes/elementtiming
    • /ko/docs/Web/HTML/Attributes/for does not exist but fell back to /en-US/docs/Web/HTML/Attributes/for
    • and 15 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
External URLs (131)

URL: /es/docs/Learn/CSS/CSS_layout/Responsive_Design
Title: Diseño receptivo


URL: /es/docs/Web/CSS/zoom
Title: zoom


URL: /es/docs/Web/CSS/At-rule
Title: Regla-At


URL: /fr/docs/Learn/CSS/CSS_layout/Responsive_Design
Title: Responsive design


URL: /fr/docs/Web/CSS/zoom
Title: zoom


URL: /fr/docs/Web/CSS/At-rule
Title: Règles @


URL: /fr/docs/Web/HTML/Element/meta/name
Title: Noms des métadonnées standard


URL: /ru/docs/Learn/CSS/CSS_layout/Responsive_Design
Title: Отзывчивый дизайн


URL: /ru/docs/Web/CSS/At-rule
Title: At-rules


URL: /ru/docs/Web/HTML/Element/meta
Title: <meta> - элемент для описания метаданных


URL: /ja/docs/Web/CSS/zoom
Title: zoom


URL: /ja/docs/Web/CSS/env
Title: env()


URL: /ja/docs/Web/CSS/At-rule
Title: アットルール


URL: /ja/docs/Web/HTML/Element/meta/name
Title: 標準メタデータ名


URL: /pt-BR/docs/Learn/CSS/CSS_layout/Responsive_Design
Title: Design Responsivo


URL: /pt-BR/docs/Web/CSS/env
Title: env()


URL: /pt-BR/docs/Web/HTML/Element/meta
Title: <meta>


URL: /ko/docs/Learn/CSS/CSS_layout/Responsive_Design
Title: 반응형 디자인


URL: /ko/docs/Web/CSS/At-rule
Title: @-규칙


URL: /ko/docs/Web/HTML/Element/meta/name
Title: 표준 메타데이터 이름

(comment last updated: 2023-07-12 17:35:31)

Copy link
Member

@SphinxKnight SphinxKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for @mdn/yari-content-fr, thanks @mems :)

@mems mems force-pushed the remove-viewport branch from 3ccbd55 to ee95de0 Compare July 12, 2023 15:18
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ja.

Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for es , Thank you!

@Graywolf9 Graywolf9 removed the request for review from davbrito July 12, 2023 17:32
@cw118 cw118 removed their request for review July 12, 2023 20:45
Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for pt-BR

@SphinxKnight
Copy link
Member

I'm going to go ahead and merge this one. Even if I don't speak Korean, the changes under /ko seems sane and consistent with the other locales.
@mdn/yari-content-ko please let me know if you disagree and would have preferred me to wait a bit longer.

@SphinxKnight SphinxKnight merged commit fbee629 into mdn:main Jul 17, 2023
@mems mems deleted the remove-viewport branch July 18, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-es Issues related to Spanish content. l10n-fr Issues related to French content. l10n-ja Issues related to Japanese content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

6 participants