Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete HTMLBaseFontElement interface #16997

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

leon-win
Copy link
Member

Description

This PR remove obsolete HTMLBaseFontElement interface from MDN translated content.

Motivation

It has been removed from en-US locale a long time ago.

Related issues and pull requests

Relates to #13499, mdn/content#18320

@leon-win leon-win requested review from a team as code owners November 16, 2023 19:48
@leon-win leon-win requested review from myshov, tristantheb, jasonren0403 and nathipg and removed request for a team November 16, 2023 19:48
@github-actions github-actions bot added l10n-fr Issues related to French content. l10n-zh Issues related to Chinese content. l10n-ru Issues related to Russian content. l10n-pt-br Issues related to Brazilian Portuguese labels Nov 16, 2023
Copy link
Contributor

github-actions bot commented Nov 16, 2023

Preview URLs

Flaws (1012)

URL: /zh-TW/docs/Web/API/Document_Object_Model
Title: 文件物件模型 (DOM)
Flaw count: 275

  • macros:
    • /zh-TW/docs/Web/API/Attr does not exist but fell back to /en-US/docs/Web/API/Attr
    • /zh-TW/docs/Web/API/CharacterData does not exist but fell back to /en-US/docs/Web/API/CharacterData
    • /zh-TW/docs/Web/API/ChildNode does not exist
    • /zh-TW/docs/Web/API/Comment does not exist but fell back to /en-US/docs/Web/API/Comment
    • /zh-TW/docs/Web/API/Document does not exist but fell back to /en-US/docs/Web/API/Document
    • and 267 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (1 in common of 2 possible)

URL: /pt-BR/docs/Web/API/Document_Object_Model
Title: Modelo de Objeto de Documento (DOM)
Flaw count: 256

  • macros:
    • /pt-BR/docs/Web/API/ChildNode does not exist
    • /pt-BR/docs/Web/API/Comment does not exist but fell back to /en-US/docs/Web/API/Comment
    • /pt-BR/docs/Web/API/CustomEvent does not exist but fell back to /en-US/docs/Web/API/CustomEvent
    • /pt-BR/docs/Web/API/DocumentType does not exist but fell back to /en-US/docs/Web/API/DocumentType
    • /pt-BR/docs/Web/API/DOMError does not exist but fell back to /en-US/docs/Web/API/DOMError
    • and 248 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (1 in common of 2 possible)

URL: /fr/docs/Web/API/Document_Object_Model
Title: Référence du DOM
Flaw count: 254

  • macros:
    • /fr/docs/Web/API/ChildNode redirects to /fr/docs/Web/API/Element
    • wrong xref macro used (consider changing which macro you use)
    • wrong xref macro used (consider changing which macro you use)
    • /fr/docs/Web/API/DOMSettableTokenList does not exist
    • /fr/docs/Web/API/MutationRecord does not exist but fell back to /en-US/docs/Web/API/MutationRecord
    • and 247 more flaws omitted
  • broken_links:
    • Can't resolve /fr/docs/Web/API/Référence_du_DOM_Gecko/Exemples
  • translation_differences:
    • Differences in the important macros (1 in common of 2 possible)

URL: /ru/docs/Web/API/Document_Object_Model
Title: Руководство по DOM
Flaw count: 227

  • macros:
    • /ru/docs/Web/API/ChildNode does not exist
    • /ru/docs/Web/API/CustomEvent does not exist but fell back to /en-US/docs/Web/API/CustomEvent
    • /ru/docs/Web/API/DocumentType does not exist but fell back to /en-US/docs/Web/API/DocumentType
    • /ru/docs/Web/API/DOMError does not exist but fell back to /en-US/docs/Web/API/DOMError
    • /ru/docs/Web/API/DOMException does not exist but fell back to /en-US/docs/Web/API/DOMException
    • and 219 more flaws omitted
  • broken_links:
    • Can't resolve /ru/docs/DOM/DOM_Reference/Введение
    • Can't resolve /ru/docs/DOM/DOM_Reference/Examples
  • translation_differences:
    • Differences in the important macros (0 in common of 2 possible)

(comment last updated: 2023-11-18 22:14:02)

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for zh-TW. Thank you @leon-win

@yin1999 yin1999 removed the request for review from jasonren0403 November 17, 2023 00:49
Copy link
Member

@saionaro saionaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for RU

@saionaro saionaro removed the l10n-ru Issues related to Russian content. label Nov 17, 2023
@yin1999 yin1999 removed the request for review from myshov November 17, 2023 09:20
@yin1999 yin1999 added the l10n-ru Issues related to Russian content. label Nov 17, 2023
Copy link
Member

@tristantheb tristantheb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for fr

Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for pt-BR

@yin1999 yin1999 removed the request for review from nathipg November 19, 2023 16:20
@yin1999 yin1999 merged commit f6b6af6 into mdn:main Nov 19, 2023
@leon-win leon-win deleted the fix/13499/remove-htmlbasefontelement branch November 19, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-fr Issues related to French content. l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content. l10n-zh Issues related to Chinese content.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants