Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Tools section from es #4876

Merged
merged 1 commit into from
Apr 4, 2022
Merged

remove Tools section from es #4876

merged 1 commit into from
Apr 4, 2022

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Mar 29, 2022

Part of #4822

Removed by running go script here

@yin1999 yin1999 requested a review from a team as a code owner March 29, 2022 01:44
@yin1999 yin1999 requested review from Graywolf9 and removed request for a team March 29, 2022 01:44
@github-actions github-actions bot added the l10n-es Issues related to Spanish content. label Mar 29, 2022
@JuanVqz
Copy link
Member

JuanVqz commented Mar 29, 2022

@yin1999 thank you for opening this PR, I'm not pretty sure what this PR does, but it seems like it didn't break any test, so, I'll approve it. 👍

EDIT: it seems like you removed the index files, why didn't we remove the folder structure under the tools folder?

@yin1999
Copy link
Member Author

yin1999 commented Mar 29, 2022

Hi @JuanVqz All files under tools folder have been removed by this pr. And there is no folder left.

And those links in Tools section are redirected to Firefox Developer Tools docs (see commits in files/es/_redirects.txt). Reference: mdn/content#14140

image

@Graywolf9
Copy link
Contributor

Thank you so much @yin1999! There's a reason to have that difference?

Captura de Pantalla 2022-03-31 a la(s) 11 49 58

@yin1999
Copy link
Member Author

yin1999 commented Apr 1, 2022

You mean we shoud apply all the redirects about /en-US/docs/Tools/* in mdn/content to the l10n repo?

This may help with some documents which do not exist but are referenced in l10n. So I have made a test about it:

test

I have added a link to /es/docs/Tools:Validators which does not exist in es (not defined in files/es/_redirects.txt neither), and mdn/yari could resolve this link correctly (to https://firefox-source-docs.mozilla.org/devtools-user/validators/index.html which is defined in files/en-us/_redirects.txt)

image

So I think we may only need to resolve those documents which is in l10n (edit: define redirects for l10n documents). Any ideas @SphinxKnight ?

@cw118
Copy link
Member

cw118 commented Apr 3, 2022

@yin1999 @Graywolf9 adding redirects for existing l10n pages should be good, I don't see the need to add more especially since yari handles the rest thanks to en-us redirects :)

@Graywolf9
Copy link
Contributor

@yin1999 @cw118 I see it, thank you much for your time and contribution!

@Graywolf9 Graywolf9 merged commit 3bea847 into mdn:main Apr 4, 2022
@yin1999 yin1999 deleted the remove-tools-es branch April 5, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-es Issues related to Spanish content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants