Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove exception [ES] #6330

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Remove exception [ES] #6330

merged 3 commits into from
Jun 17, 2022

Conversation

JuanVqz
Copy link
Member

@JuanVqz JuanVqz commented Jun 17, 2022 •
edited
Loading

closes #6333

  • files/es/web/api/crypto/getrandomvalues/index.html
  • files/es/web/api/element/closest/index.html

Removal of {{exception}} macro

@JuanVqz
Remove exception [ES]
0dbd3e3 
- [x] files/es/web/api/crypto/getrandomvalues/index.html
- [x] files/es/web/api/element/closest/index.html

[Removal of {{exception}} macro](https://github.com/orgs/mdn/discussions/64)
@JuanVqz JuanVqz requested a review from a team as a code owner June 17, 2022 13:25
@JuanVqz JuanVqz requested review from marcelozarate and removed request for a team June 17, 2022 13:25
@github-actions github-actions bot added the l10n-es Issues related to Spanish content. label Jun 17, 2022
@JuanVqz JuanVqz requested review from Graywolf9 and Jalkhov June 17, 2022 13:25
@github-actions
Copy link
Contributor

github-actions bot commented Jun 17, 2022 •
edited
Loading

Preview URLs

Flaws

URL: /es/docs/Web/API/Element/closest
Title: Element.closest()
on GitHub
Flaw count: 6

  • macros:
    • wrong xref macro used (consider changing which macro you use)
    • This macro has been deprecated, and should be removed.
    • This macro has been deprecated, and should be removed.
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /es/docs/Web/CSS/Introducción/Selectors
  • translation_differences:
    • Differences in the important macros (0 in common of 5 possible)

URL: /es/docs/Web/API/Crypto/getRandomValues
Title: Crypto.getRandomValues()
on GitHub
Flaw count: 12

  • macros:
    • /es/docs/Glossary/user_agent does not exist but fell back to /en-US/docs/Glossary/User_agent
    • /es/docs/Web/JavaScript/Reference/Int8Array does not exist
    • /es/docs/Web/JavaScript/Reference/Int16Array does not exist
    • /es/docs/Web/JavaScript/Reference/Uint16Array does not exist
    • /es/docs/Web/JavaScript/Reference/Int32Array does not exist
    • and 5 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (1 in common of 4 possible)

External URLs

URL: /es/docs/Web/API/Element/closest
Title: Element.closest()
on GitHub

No new external URLs

URL: /es/docs/Web/API/Crypto/getRandomValues
Title: Crypto.getRandomValues()
on GitHub

No new external URLs

(this comment was updated 2022-06-17 18:52:35.116872)

@Graywolf9 Graywolf9 mentioned this pull request Jun 17, 2022
Closed
6 tasks
Graywolf9
Graywolf9 requested changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias por la rápida atención.

Te dejo algunos comentarios

Dejo el issue para atender los documentos de manera completa en: #6333

files/es/web/api/crypto/getrandomvalues/index.html Outdated Show resolved Hide resolved
files/es/web/api/element/closest/index.html Outdated Show resolved Hide resolved
JuanVqz and others added 2 commits June 17, 2022 12:56
@JuanVqz @Graywolf9
Update files/es/web/api/element/closest/index.html
caa6043 
Co-authored-by: Alexander <alexander_belial999@hotmail.com>
@JuanVqz @Graywolf9
Apply suggestions from code review
97226d5 
Co-authored-by: Alexander <alexander_belial999@hotmail.com>
@Graywolf9
Copy link
Contributor

Muchas gracias por valioso tiempo y colaboración!

@Graywolf9 Graywolf9 merged commit 5278a0f into mdn:main Jun 17, 2022
@JuanVqz JuanVqz deleted the remove-exception-es branch June 17, 2022 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Graywolf9 Graywolf9 Graywolf9 approved these changes

@marcelozarate marcelozarate Awaiting requested review from marcelozarate marcelozarate is a code owner automatically assigned from mdn/yari-content-es

@Jalkhov Jalkhov Awaiting requested review from Jalkhov

Assignees
No one assigned
Labels
l10n-es Issues related to Spanish content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove exception in es locale
2 participants
@JuanVqz @Graywolf9