Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update page-report-es.yml #9505

Merged
merged 7 commits into from
Jan 31, 2023
Merged

Update page-report-es.yml #9505

merged 7 commits into from
Jan 31, 2023

Conversation

JuanVqz
Copy link
Member

@JuanVqz JuanVqz commented Oct 25, 2022 •
edited by Graywolf9
Loading

Description

Updating content to the Spanish language.

Motivation

Make page reports easy to read for Spanish tongue contributors

Additional details

Thank you @IvanAquino for contributing to this translation.

Related issues and pull requests

Related to #9073, #8918

@JuanVqz JuanVqz added the l10n-es Issues related to Spanish content. label Oct 25, 2022
@JuanVqz JuanVqz self-assigned this Oct 25, 2022
@github-actions github-actions bot added system Infrastructure and configuration for the project and removed l10n-es Issues related to Spanish content. labels Oct 25, 2022
@JuanVqz
Copy link
Member Author

JuanVqz commented Oct 25, 2022 •
edited
Loading

@mdn/yari-content-es it would be nice if you have a look at it and share your thoughts. 🚀

JuanVqz
JuanVqz commented Oct 25, 2022
View reviewed changes
.github/ISSUE_TEMPLATE/page-report-es.yml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/page-report-es.yml Outdated Show resolved Hide resolved
@JuanVqz JuanVqz mentioned this pull request Oct 26, 2022
Closed
@Graywolf9
Copy link
Contributor

Muchas gracias! @JuanVqz te he dejado algunos comentarios

JuanVqz and others added 6 commits October 26, 2022 12:22
@JuanVqz @Graywolf9
Update .github/ISSUE_TEMPLATE/page-report-es.yml
bbed545 
Co-authored-by: Alexander <alexander_belial999@hotmail.com>
@JuanVqz
Update .github/ISSUE_TEMPLATE/page-report-es.yml
d73fe63
@JuanVqz
Update .github/ISSUE_TEMPLATE/page-report-es.yml
003b31d
@JuanVqz @Graywolf9
Update .github/ISSUE_TEMPLATE/page-report-es.yml
afe51e5 
Co-authored-by: Alexander <alexander_belial999@hotmail.com>
@JuanVqz @Graywolf9
Update .github/ISSUE_TEMPLATE/page-report-es.yml
10e3403 
Co-authored-by: Alexander <alexander_belial999@hotmail.com>
@JuanVqz @Graywolf9
Update .github/ISSUE_TEMPLATE/page-report-es.yml
ba478f2 
Co-authored-by: Alexander <alexander_belial999@hotmail.com>
@JuanVqz JuanVqz marked this pull request as ready for review October 26, 2022 23:06
@JuanVqz JuanVqz requested a review from a team as a code owner October 26, 2022 23:06
caugner
caugner reviewed Oct 27, 2022
View reviewed changes
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @Graywolf9 approves, I can merge.

@JuanVqz JuanVqz requested a review from Graywolf9 October 27, 2022 14:06
@fwqaaq fwqaaq mentioned this pull request Oct 27, 2022
Merged
@JuanVqz
Copy link
Member Author

JuanVqz commented Oct 28, 2022

@Graywolf9 cuando tengas tiempo de aprobar el PR por favor?

@JuanVqz
Copy link
Member Author

JuanVqz commented Nov 21, 2022

@Graywolf9 cuando tengas tiempo de aprobar el PR por favor?

@Graywolf9 solo para recordarte de este pr. cuando tengas tiempo de revisarlo/aprobarlo, gracias!

Graywolf9
Graywolf9 approved these changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@Graywolf9 Graywolf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for all your help! @JuanVqz

So sorry about the late, when the bot remove the l10n-es tag this keeps off of my radar 😅

But this is perfect to merge, thanks for your patience @caugner

@caugner caugner merged commit 564ca00 into main Jan 31, 2023
@caugner caugner deleted the JuanVqz-patch-2 branch January 31, 2023 18:13
@caugner
Copy link
Contributor

caugner commented Jan 31, 2023

Great work, @JuanVqz and @Graywolf9! 🎉

@Graywolf9 Graywolf9 mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Graywolf9 Graywolf9 Graywolf9 approved these changes

@caugner caugner caugner approved these changes

Assignees

@JuanVqz JuanVqz

Labels
system Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JuanVqz @Graywolf9 @caugner