Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed for manifest version 3 and compatibility to Chrome and CCleaner browsers #555

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gum1900
Copy link

@gum1900 gum1900 commented Mar 8, 2024

Description

I changed the "beastify" extension to

  1. to run with manifest version 3
  2. to make compatible with Chrome and CC cleaner browsers

Motivation

The changes demonstrate Mozilla extensions running with manifest version 3.

Additional details

Unfortunately the change run very well with Chrome and CCleaner browsers, but does not run well with Firefox browser. On Firefox browser, content JS does not load. Pop-up and website page Debuggers does not provide any further information except a console message of "undefined: undefined" on the pop-up debugger. I have raised a bug "https://bugzilla.mozilla.org/show_bug.cgi?id=1884298" (Bug ID: 1884298) with Mozilla.

Nevertheless, the changes can still be helpful for developers writing compatible extensions with manifest version 3

Related issues and pull requests

Bugzilla bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1884298

Copy link

github-actions bot commented Mar 8, 2024

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Apr 7, 2024
@Rob--W
Copy link
Member

Rob--W commented Oct 1, 2024

A mix of MV2 and MV3 is confusing, we should improve the documentation on MDN.

This PR converts an example to MV3, but does not include browser_specific_settings.gecko.id. While Firefox does not require that, the extension store at addons.mozilla.org does require it. I haven't decided whether we should include it in all examples (at the risk of the user trying to submit it to AMO in unmodified form) or to exclude it (at the risk of the user getting stuck at the last minute, when trying to upload to AMO).

Another consideration is that Chrome currently warns when browser_specific_settings is present. This will be fixed in Chrome 131, to not warn any more.

@github-actions github-actions bot removed the idle Issues and pull requests with no activity for three months. label Oct 2, 2024
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants