Skip to content

Commit

Permalink
smartlink to fallback on en-US (#3133)
Browse files Browse the repository at this point in the history
* smartLink to fallback on en-US

Fixes #3053

* finish

* feedbacked
  • Loading branch information
peterbe authored Mar 9, 2021
1 parent 74769cd commit cc94971
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 0 deletions.
6 changes: 6 additions & 0 deletions client/src/document/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,12 @@
}
}

.only-in-en-us {
span {
font-size: $small-font-size;
}
}

.article {
padding: ($base-spacing / 2) $base-spacing $base-spacing;

Expand Down
21 changes: 21 additions & 0 deletions kumascript/src/api/web.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,27 @@ module.exports = {
page.url + hrefhash
}"${titleAttribute}${flawAttribute}>${content}</a>`;
}
if (!href.toLowerCase().startsWith("/en-us/")) {
// Before flagging this as a broken-link flaw, see if it's possible to
// change it to the en-US URL instead.
const hrefSplit = href.split("/");
hrefSplit[1] = "en-US";
const enUSPage = this.info.getPageByURL(hrefSplit.join("/"));
if (enUSPage.url) {
// But it's still a flaw. Record it so that translators can write a
// translated document to "fill the hole".
flaw = this.env.recordNonFatalError(
"broken-link",
`${hrefpath} does not exist but fallbacked on ${enUSPage.url}`
);
flawAttribute = ` data-flaw-src="${util.htmlEscape(flaw.macroSource)}"`;
return (
'<a class="only-in-en-us" ' +
'title="Currently only available in English" ' +
`href="${enUSPage.url}"${flawAttribute}>${content} <span>(en-US)</span></a>`
);
}
}
flaw = this.env.recordNonFatalError(
"broken-link",
`${hrefpath} does not exist`
Expand Down

0 comments on commit cc94971

Please sign in to comment.