Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sporadic errors in headless tests relating to switching language #3116

Closed
peterbe opened this issue Mar 3, 2021 · 1 comment · Fixed by #3118
Closed

Sporadic errors in headless tests relating to switching language #3116

peterbe opened this issue Mar 3, 2021 · 1 comment · Fixed by #3118
Assignees
@peterbe

Comments

@peterbe
Copy link
Contributor

peterbe commented Mar 3, 2021

See https://github.com/mdn/yari/runs/2023484911?check_suite_focus=true for example.
It seems to have started happening since #2839 landed. It doesn't always fail. For example, Schalk's PR didn't fail in the last CI build before he merged it.
It's probably something flaky in the puppeteer-expect testing due to "network luck".

Let's fail forward and try to make that test stable.
@peterbe peterbe self-assigned this Mar 3, 2021
@peterbe peterbe mentioned this issue Mar 3, 2021
Merged
peterbe added a commit to peterbe/yari that referenced this issue Mar 3, 2021
@peterbe
don't wait for networkidle2 unless a reason to
a62bbaa 
Fixes mdn#3116
@peterbe
Copy link
Contributor Author

peterbe commented Mar 3, 2021

Found the culprit. https://github.com/mdn/yari/pull/2839/files#r586729857

@peterbe peterbe mentioned this issue Mar 3, 2021
Merged
peterbe added a commit that referenced this issue Mar 3, 2021
@peterbe
don't wait for networkidle2 unless a reason to (#3118)
3c90b0e 
Fixes #3116
peterbe added a commit to peterbe/yari that referenced this issue Jun 1, 2021
@peterbe
don't wait for networkidle2 unless a reason to (mdn#3118)
811e261 
Fixes mdn#3116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterbe peterbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

don't wait for networkidle2 unless a reason to peterbe/yari
1 participant
@peterbe