Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe HTML should be a breaking flaw #3177

Closed
peterbe opened this issue Mar 9, 2021 · 0 comments · Fixed by #3192
Closed

Unsafe HTML should be a breaking flaw #3177

peterbe opened this issue Mar 9, 2021 · 0 comments · Fixed by #3192
Assignees
@peterbe

Comments

@peterbe
Copy link
Contributor

peterbe commented Mar 9, 2021

The scenario is that someone tries to sneak in some unsafe HTML into a PR. It should break the PR build (on the content) and raise awareness/attention so it doesn't easily get merged.
For example <script> or <p onmouseover="bad()">.
@peterbe peterbe self-assigned this Mar 10, 2021
peterbe added a commit to peterbe/yari that referenced this issue Mar 10, 2021
@peterbe
Unsafe HTML should be a breaking flaw
6e6432e 
Part of mdn#3177
@peterbe peterbe mentioned this issue Mar 11, 2021
Merged
escattone added a commit that referenced this issue Mar 11, 2021
@peterbe @escattone
unsafe html should be a breaking flaw (#3192)
7766fd2 
* Unsafe HTML should be a breaking flaw

Part of #3177

* tests

* undo unnecessary if statement

* restore newline

* Update testing/content/files/en-us/web/unsafe_html/index.html

* Update testing/content/files/en-us/web/unsafe_html/index.html

Co-authored-by: Ryan Johnson <escattone@gmail.com>
@peterbe peterbe mentioned this issue Mar 12, 2021
Closed
peterbe added a commit to peterbe/yari that referenced this issue Jun 1, 2021
@peterbe @escattone
unsafe html should be a breaking flaw (mdn#3192)
96d2786 
* Unsafe HTML should be a breaking flaw

Part of mdn#3177

* tests

* undo unnecessary if statement

* restore newline

* Update testing/content/files/en-us/web/unsafe_html/index.html

* Update testing/content/files/en-us/web/unsafe_html/index.html

Co-authored-by: Ryan Johnson <escattone@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterbe peterbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unsafe html should be a breaking flaw peterbe/yari
1 participant
@peterbe