-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HTTP 404 page #3931
Comments
What should that link there be if the URL was something like /fr/docs/Web/Pagenotfound? |
I'm happy with this, yes :). The only thing might be whether instead of directing them to https://github.com/mdn/content#contributing-to-the-content-of-mdn-web-docs (effectively asking them to fix it themselves) we direct them to https://github.com/mdn/content/issues (asking them to ask for it to be fixed). But I can see arguments on both sides, and this is a big improvement on what we have now. |
Great! I don't want to derail this being implemented, so as an aside, @wbamberg perhaps the first thing in https://github.com/mdn/content#contributing-to-the-content-of-mdn-web-docs could be a call to create issues, and recognise that as a contribution. |
How about this then:
?? |
I like having 2 separate links, an easy path to just file an issue as well as the link to the README. I think this is better than just sending people to the README, which is a forbidding document even if it links to the issue tracker early on. I think "first" is odd in the second link as it implies that you have to fix the issue still after filing it. Is that what we want to imply? If it were me I'd swap the order of "file an issue" and "fix it yourself":
|
Sounds good. This is what I think we are all agreeing to (note that I don't like starting sentences with Or). Both of those points could be on the same line if we want.
|
sold! |
Soz just catching up on this... I'm concluding yes this is good - after writing a whole paragraph on thoughts and that's the tldr 😄 |
@hamishwillee In #7070, it would have been useful to mention this issue. 😉 |
Yes it would - sorry, my memory of silent year old issues perhaps not what it should be :-0 |
Please update the HTTP 404 page as show:
This follows discussion here: https://github.com/mdn/yari/discussions/3890
The text was updated successfully, but these errors were encountered: