Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(build): improve expected document path error message #11606

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

PassionPenguin
Copy link
Contributor

Summary

hopefully fixes #11531

Problem

the thrown error message of build script is not obvious enough.

Solution

added the expected path to the very end of the error message

@PassionPenguin PassionPenguin requested a review from a team as a code owner August 7, 2024 15:08
@caugner caugner changed the title feat: better logging enhance(build): improve expected document path error message Aug 9, 2024
@caugner
Copy link
Contributor

caugner commented Aug 9, 2024

@PassionPenguin Can you please check the referenced issue? #11531 is a PR, not an issue. 😕

@PassionPenguin
Copy link
Contributor Author

@PassionPenguin Can you please check the referenced issue? #11531 is a PR, not an issue. 😕

sorry...that's #10277 (#10277)
image

@github-actions github-actions bot added the idle label Sep 15, 2024
@PassionPenguin
Copy link
Contributor Author

@PassionPenguin Can you please check the referenced issue? #11531 is a PR, not an issue. 😕

sorry...that's #10277 (#10277)

image

Hi @caugner! I found this PR has been opened for 2mo without further request or question? Would you like to have a review on this?

@argl
Copy link
Contributor

argl commented Sep 29, 2024

@LeoMcA The PR looks good to me, could you have a quick look at why the bundle size action fails?

@skyclouds2001
Copy link
Contributor

it seems to failed with #11831 for the same reason

Copy link
Contributor

@argl argl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@argl argl merged commit afa30bc into mdn:main Oct 1, 2024
12 checks passed
@PassionPenguin PassionPenguin deleted the patch-1 branch October 2, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants