Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JTS to TOC #2471

Closed
wants to merge 1 commit into from
Closed

JTS to TOC #2471

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 12, 2021

@peterbe
Copy link
Contributor

peterbe commented Jan 12, 2021

I'm not convinced. It's in a side-bar after all. GitHub Docs calls it "In this article" which is nice. Accurate.

@ghost
Copy link
Author

ghost commented Jan 12, 2021

Even the code uses toc and It has a Wikipedia article 🤷🏻‍♂️
https://en.m.wikipedia.org/w/index.php?search=Jump+to+section&ns0=1

@ghost
Copy link
Author

ghost commented Jan 12, 2021

I still want to call It
Table of contents

but i want to say that Is not a table but a ul 🤯

@peterbe
Copy link
Contributor

peterbe commented Jan 12, 2021

"Table of contents" is usually something you have in the content. On the first page. Not on the side.

@ghost
Copy link
Author

ghost commented Jan 12, 2021

A table of contents, usually headed simply Contents and abbreviated informally as TOC, is a list, usually found on a page before the start of a written work, of its chapter or section titles or brief descriptions with their commencing page numbers.

  • document is a chapter
  • origin is a book

In general is the content in the context like when you logs the entries in an object.

🌳

Table of contents is in the content so links to self? 🤔

@ghost
Copy link
Author

ghost commented Jan 12, 2021

I'm not convinced. It's in a side-bar after all. GitHub Docs calls it "In this article" which is nice. Accurate.

Table of contents in this article

And We have to use a table.

Instead

Unordered list of contents in this article

@ghost
Copy link
Author

ghost commented Jan 12, 2021

Side issue

mdn/content provides contents so It could be called mdn/contents.

@ghost
Copy link
Author

ghost commented Jan 12, 2021

Yes it could be moved but in separate PRs.
I used to update in a commit and move in other commit.

@ghost
Copy link
Author

ghost commented Jan 12, 2021

<article>
<h1>Title</h1>
<section>
<h1>Table of contents</h1>
<table/>
</section>
<section/>
<section/>
</article>

draft/concept

@peterbe
Copy link
Contributor

peterbe commented Jan 15, 2021

Let's not worry about making the change. But please feel free to start a discussion about changing the English. I don't think we should just jump into an edit without consent from the content folks.

@peterbe peterbe closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant