Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change jump to section to table of contents #2875

Merged
merged 1 commit into from
Feb 10, 2021
Merged

fix: change jump to section to table of contents #2875

merged 1 commit into from
Feb 10, 2021

Conversation

schalkneethling
Copy link

Reword the heading from "Jump to section" to "Table of contents"

fix #2874

fix: change jump to section to table of contents
e4fdce4 
Reword the heading from "Jump to section" to "Table of contents"

fix #2874
@schalkneethling schalkneethling mentioned this pull request Feb 10, 2021
Merged
peterbe
peterbe approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this way. It's a bit weird that a ToC is in the sidebar but the expression is so familiar and affording. Whereas "Jump to section" requires me to think and wonder what it might mean.

@chrisdavidmills
Copy link
Contributor

This change has been formally approved by the MDN content team.

@ghost
Copy link

ghost commented Feb 10, 2021

a ToC is in the sidebar

Nice point. 💭

@ghost
Copy link

ghost commented Feb 10, 2021 •
edited by ghost
Loading

Consider opening an issue to refactor this component by removing React features in favor of a more vanilla and accessible solution in line with MDN itself ...

@schalkneethling schalkneethling merged commit 7cad1f7 into mdn:master Feb 10, 2021
@schalkneethling schalkneethling deleted the 2874-jump-to-section-to-toc branch February 10, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbe peterbe peterbe approved these changes

Assignees

@peterbe peterbe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change "Jump to section" to "Table of contents"
3 participants
@schalkneethling @chrisdavidmills @peterbe