Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make Flaws Dashboard work in mdn/content #4093

Merged
merged 1 commit into from
Jul 7, 2021
Merged

make Flaws Dashboard work in mdn/content #4093

merged 1 commit into from
Jul 7, 2021

Conversation

peterbe
Copy link
Contributor

@peterbe peterbe commented Jun 25, 2021

Fixes #4082

First, test in regular yari:

# One terminal
yarn dev

# Another terminal
yarn build

And then open http://localhost:3000/en-US/_flaws in your browser. Should show stuff.

Ultimately the raison-d'etre for this PR is so that mdn/content#6349 can start to work.

@peterbe peterbe requested a review from fiji-flo June 25, 2021 19:04
@peterbe peterbe mentioned this pull request Jun 25, 2021
Closed
Gregoor
Gregoor approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@Gregoor Gregoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works!

@Gregoor Gregoor merged commit bad491c into mdn:main Jul 7, 2021
@peterbe peterbe deleted the 4082-make-flaws-dashboard-work-in-mdncontent branch July 7, 2021 11:24
@peterbe peterbe mentioned this pull request Jul 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gregoor Gregoor Gregoor approved these changes

@fiji-flo fiji-flo Awaiting requested review from fiji-flo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaws Dashboard doesn't work in mdn/content
2 participants
@peterbe @Gregoor