Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bcd): show history chronologically + sort #5649

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Mar 16, 2022

  1. Previously, we would simply expect that the BCD history is ordered by version number, but this is not always the case.
    Now, we reorder the BCD history ourselves, to be sure.
  2. Previously, the support history was going backward.
    This was misleading, because notes appeared at the wrong position.
    Now, we show the history in chronological order, starting with the oldest entry (version), and going forward.

Best examples for these are the Firefox support histories for:

Fixes #5462.


Screenshots

Before

Screenshot 2022-03-16 at 22 47 18

After

Screenshot 2022-03-16 at 22 54 32


How did you test this change?

  1. Opened http://localhost:3000/en-US/docs/Web/CSS/appearance#browser_compatibility and http://localhost:3000/en-US/docs/Web/CSS/gradient/linear-gradient()#browser_compatibility locally.

Previously, we would simply expect that the BCD history is ordered
by version number, but this is not always the case.

Now, we reorder the BCD history ourselves, to be sure.
@caugner caugner added the browser-compat issues related to the browser compatibility data tables (BCD) label Mar 16, 2022
Previously, the support history was going backward.

This was misleading, because notes appeared at the wrong position.

Now, we show the history in chronological order, starting with the
oldest entry (version), and going forward.
@caugner caugner changed the title fix(bcd): sort history by version fix(bcd): show history chronologically + sort Mar 16, 2022
Copy link
Contributor

@schalkneethling schalkneethling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @caugner! One comment but, this lgtm

build/document-extractor.js Outdated Show resolved Hide resolved
Co-authored-by: Schalk Neethling <schalk.neethling@mechanical-ink.co.za>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-compat issues related to the browser compatibility data tables (BCD)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New BCD timeline view is possibly confusing to some users
2 participants