Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps)!: migrate from yarn to npm + workspaces #6322

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

chore(deps)!: migrate from yarn to npm + workspaces #6322

wants to merge 16 commits into from

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 20, 2022

Experimental PR to see how easy a switch back to npm would go.

⚠️ This PR is blocked by [this error.](https://github.com//pull/6322#issuecomment-1133227129): ``` Error: 17:56:38 Error: Cannot find module 'cookie' Require stack: - /home/runner/work/yari/yari/libs/get-locale/index.js - /home/runner/work/yari/yari/deployer/aws-lambda/content-origin-request/index.js - /home/runner/work/yari/yari/deployer/aws-lambda/tests/server.js ```

To update this PR:
  1. Run git rebase -i upstream/main
  2. Choose edit for the first two commits.
  3. Run git ls-files package-lock.json '**/package-lock.json' | xargs -n 1 dirname | xargs -n 1 -I % sh -c 'pushd %; rm -rf node_modules package-lock.json yarn.lock; npm install; popd'
  4. Run git commit --amend --date=now
  5. Run git rebase --continue

@caugner caugner force-pushed the npm branch 2 times, most recently from afe52b9 to 1552cfb Compare May 20, 2022 09:04
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label May 20, 2022
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before we can merge this.

@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label May 20, 2022
@caugner caugner force-pushed the npm branch 2 times, most recently from f6a6604 to db1db7d Compare May 20, 2022 17:47
@caugner
Copy link
Contributor Author

caugner commented May 20, 2022

I have no clue what causes this error:

Error:  17:56:38 Error: Cannot find module 'cookie'
Require stack:
- /home/runner/work/yari/yari/libs/get-locale/index.js
- /home/runner/work/yari/yari/deployer/aws-lambda/content-origin-request/index.js
- /home/runner/work/yari/yari/deployer/aws-lambda/tests/server.js
____STDERR____
Error: Cannot find module 'cookie'
Require stack:
- /home/runner/work/yari/yari/libs/get-locale/index.js
- /home/runner/work/yari/yari/deployer/aws-lambda/content-origin-request/index.js
- /home/runner/work/yari/yari/deployer/aws-lambda/tests/server.js
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
    at Function.Module._load (node:internal/modules/cjs/loader:778:27)
    at Module.require (node:internal/modules/cjs/loader:1005:19)
    at require (node:internal/modules/cjs/helpers:102:18)
    at Object.<anonymous> (/home/runner/work/yari/yari/libs/get-locale/index.js:1:19)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Object.nodeDevHook [as .js] (/home/runner/work/yari/yari/deployer/aws-lambda/tests/node_modules/node-dev/lib/hook.js:60:7)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)

(I even tried to add cookie everywhere, and it had no effect.)

@caugner caugner added the help wanted If you know something about this topic, we would love your help! label May 20, 2022
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label May 23, 2022
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before we can merge this.

@caugner caugner force-pushed the npm branch 2 times, most recently from b512d07 to e79bf43 Compare May 23, 2022 13:17
@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label May 23, 2022
@caugner caugner force-pushed the npm branch 4 times, most recently from 98bf5a6 to 87a0864 Compare May 23, 2022 14:19
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label May 23, 2022
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before we can merge this.

@caugner caugner mentioned this pull request May 30, 2022
@caugner caugner changed the title [DNM] Migrate from yarn v1 to npm [DNM] build(deps): switch from yarn to npm May 30, 2022
@github-actions github-actions bot added dependencies Pull requests that update a dependency file deployer Deployment (currently using AWS S3 and AWS Lambda) github-actions markdown markdown related issues and pull requests python Pull requests that update Python code labels May 30, 2022
scripts/testing.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot added macros tracking issues related to kumascript macros merge conflicts 🚧 Please rebase onto or merge the latest main. and removed idle labels Apr 20, 2023
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the idle label Oct 14, 2024
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label Oct 15, 2024
@github-actions github-actions bot added the idle label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud-function dependencies Pull requests that update a dependency file deployer Deployment (currently using AWS S3 and AWS Lambda) filecheck github-actions help wanted If you know something about this topic, we would love your help! idle internal macros tracking issues related to kumascript macros markdown markdown related issues and pull requests merge conflicts 🚧 Please rebase onto or merge the latest main. placement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants