-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix icons displayed in BCD cells #6811
Conversation
The reason for the switch in logic was pages like https://developer.mozilla.org/en-US/docs/Web/CSS/flex-flow#browser_compatibility. This will go back to showing Firefox as needing a vendor prefix, since support for a vendor prefix was added after support without a vendor prefix. That's why my proposed fix was #6663 See also #5721 |
Actually, this PR's intent is to do the opposite, and NOT show needing a vendor prefix when it shouldn't. On https://developer.mozilla.org/en-US/docs/Web/CSS/transition#browser_compatibility, such an issue can be found. It seems that #6663 fixes a good chunk of the problems, but there's still one or two that can be found. One of the benefits of this approach is that it will always match the result from the To help show the changes this PR makes, this is the And to show that other pages like |
Oh right, I forgot I added a ranking system in #5946 to that function. This makes sense then, yeah, Using it wasn't an option before since I hadn't changed it yet. In that case, my feedback is this: Would this work the same if you remove those three functions and switch back to the pre- #5721 statements? |
In other words, just |
Sure thing, changes coming right up! |
Note: Also fixes mdn/browser-compat-data#16839 and fixes mdn/browser-compat-data#16833 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
This PR fixes the rendering of the
prefix
,altname
andflags
icons on BCD cells to ensure they aren't unintentionally shown when not applicable. This should help reduce issues and confusion such as mdn/browser-compat-data#17208.