Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(macros): Remove {{DeprecatedGeneric}} and {{DeprecatedBadge}} #8199

Merged
merged 7 commits into from
Mar 4, 2023

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Feb 12, 2023

The {{DeprecatedGeneric}} and {{DeprecatedBadge}} macros were not used on their own (except accidentally), and {{deprecated_inline}} was preferred. This merges {{DeprecatedGeneric}} into {{Deprecated_Header}} and merges {{DeprecatedBadge}} into {{deprecated_inline}}.

Depends on mdn/translated-content#11585 and mdn/translated-content#11588.

…ge}} into {{Deprecated_Inline}}

The `{{DeprecatedGeneric}}` and `{{DeprecatedBadge}}` macros were not used on their own (except accidentally), and `{{deprecated_inline}}` was preferred.  This deletes `{{DeprecatedGeneric}}` entirely and merges `{{DeprecatedBadge}}` into `{{deprecated_inline}}`.

Depends on mdn/translated-content#11584.
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Feb 12, 2023
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Deprecated_Header is still using DeprecatedGeneric. 😕

@queengooborg
Copy link
Collaborator Author

Huh, odd, yarn tool macro-usage-report didn't seem to catch that...

@queengooborg queengooborg changed the title refactor(macros): Remove {{DeprecatedGeneric}}; merge {{DeprecatedBadge}} into {{Deprecated_Inline}} refactor(macros): Remove {{DeprecatedGeneric}} and {{DeprecatedBadge}} Feb 18, 2023
@caugner
Copy link
Contributor

caugner commented Feb 20, 2023

Huh, odd, yarn tool macro-usage-report didn't seem to catch that...

For me, they show up with yarn tool macro-usage-report --format json:

image

@caugner caugner merged commit ed169ef into mdn:main Mar 4, 2023
@queengooborg queengooborg deleted the macros/deprecated branch March 4, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants