Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency ws to 7.4.6 [SECURITY] - autoclosed #47

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 23, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change
ws 7.2.3 -> 7.4.6

GitHub Vulnerability Alerts

CVE-2021-32640

Impact

A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server.

Proof of concept

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();

  value.trim().split(/ *, */);

  const end = process.hrtime.bigint();

  console.log('length = %d, time = %f ns', length, end - start);
}

Patches

The vulnerability was fixed in ws@7.4.6 (websockets/ws@00c425e) and backported to ws@6.2.2 (websockets/ws@78c676d) and ws@5.2.3 (websockets/ws@76d47c1).

Workarounds

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

Credits

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.


Configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@mdnorman mdnorman merged commit 53b1f98 into master Jun 23, 2021
@mdnorman mdnorman deleted the renovate/npm-ws-vulnerability branch June 23, 2021 03:21
@renovate renovate bot changed the title Update dependency ws to 7.4.6 [SECURITY] Update dependency ws to 7.4.6 [SECURITY] - autoclosed Jun 23, 2021
mdnorman added a commit that referenced this pull request Aug 1, 2021
Update dependency webpack-command to v0.5.1
mdnorman added a commit that referenced this pull request Aug 22, 2021
chore(deps): update dependency ts-jest to v27.0.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants