Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing oldest OpenMDAO install #412

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Fixing oldest OpenMDAO install #412

merged 1 commit into from
Jun 20, 2023

Conversation

kanekosh
Copy link
Contributor

@kanekosh kanekosh commented Jun 19, 2023

Purpose

This PR fixed the build with the oldest dependencies (specifically, the installation of OpenMDAO 3.15.0)

Expected time until merged

Soon

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #412 (853b2e3) into main (9f592ae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #412   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files         103      103           
  Lines        6412     6412           
=======================================
  Hits         6061     6061           
  Misses        351      351           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kanekosh kanekosh marked this pull request as ready for review June 19, 2023 21:41
@kanekosh kanekosh requested a review from a team as a code owner June 19, 2023 21:41
@eytanadler
Copy link
Collaborator

Does the old wheel version automatically use an older pip? Why is the old pip version no longer necessary?

@kanekosh
Copy link
Contributor Author

Since I dropped --upgrade the pip is not upgraded to the latest. On my local machine, the build also worked with the newer pip (23.1.2), but I don't think we need the latest pip for the oldest build.

The pip version no longer matters here because with the older wheel, we can now build the wheel for OpenMDAO==3.15.0, thus no need to revert to the legacy setup.py install (that was the reason I pinned to the old pip version previously).

@eytanadler
Copy link
Collaborator

Since I dropped --upgrade the pip is not upgraded to the latest. On my local machine, the build also worked with the newer pip (23.1.2), but I don't think we need the latest pip for the oldest build.

The pip version no longer matters here because with the older wheel, we can now build the wheel for OpenMDAO==3.15.0, thus no need to revert to the legacy setup.py install (that was the reason I pinned to the old pip version previously).

Makes sense, good find. I'm going to give this a shot on mdolab/openconcept#53 too.

@eytanadler eytanadler merged commit 2567ea9 into main Jun 20, 2023
@kanekosh kanekosh deleted the fix_old_om branch June 28, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants