Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref axis #413

Merged
merged 6 commits into from
Jul 29, 2023
Merged

Ref axis #413

merged 6 commits into from
Jul 29, 2023

Conversation

lucaeros
Copy link
Contributor

Purpose

Following the previous PR on chord_scaling_pos, the aim of this PR is to add a new setting called "ref_axis_pos" (stands for reference axis position) that is generalizing the "chord_scaling_pos" for every geometric transformation that needed it : twist (rotate), span (stretch), taper, chord (scaleX). Setting the ref_axis_pos, the user can decide around with reference line the geometric variable will be applied, ref_axis_pos = 0.25 is the quarter of chord and was the default one. ref_axis_pos = 1 is around the trailing edge, ref_axis_pos = 0 is around leading edge.

Expected time until merged

a week

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Verified that the geometric variable have the correct behavior on simple cases (opt_chord.py, opt_twist.py)

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@lucaeros lucaeros requested a review from a team as a code owner July 12, 2023 15:27
@lucaeros lucaeros requested review from lamkina and kanekosh July 12, 2023 15:27
@eytanadler eytanadler requested review from eytanadler and removed request for lamkina July 12, 2023 15:28
@eytanadler
Copy link
Collaborator

Please add sudo apt-get update to the beginning of the Install OpenVSP step in the GitHub Actions workflow. Hopefully this will fix the 404 error preventing the actions from properly installing packages. Including the apt update is noted here, which is linked to from a GitHub issue about a similar problem.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #413 (e95326d) into main (5ebabd1) will increase coverage by 0.00%.
The diff coverage is 98.61%.

@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         103      103           
  Lines        6445     6448    +3     
=======================================
+ Hits         6091     6094    +3     
  Misses        354      354           
Files Changed Coverage Δ
openaerostruct/geometry/geometry_mesh.py 98.63% <83.33%> (-0.06%) ⬇️
openaerostruct/__init__.py 100.00% <100.00%> (ø)
...rostruct/geometry/geometry_mesh_transformations.py 99.67% <100.00%> (+<0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

kanekosh
kanekosh previously approved these changes Jul 14, 2023
eytanadler
eytanadler previously approved these changes Jul 18, 2023
@eytanadler
Copy link
Collaborator

Please pull the latest main to fix the build and also bump the version to 2.7.0

@eytanadler eytanadler self-requested a review July 28, 2023 21:01
@eytanadler eytanadler requested a review from kanekosh July 29, 2023 02:46
@kanekosh kanekosh merged commit f2f974f into mdolab:main Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants