-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref axis #413
Ref axis #413
Conversation
Please add |
Codecov Report
@@ Coverage Diff @@
## main #413 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 103 103
Lines 6445 6448 +3
=======================================
+ Hits 6091 6094 +3
Misses 354 354
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Please pull the latest main to fix the build and also bump the version to 2.7.0 |
Purpose
Following the previous PR on chord_scaling_pos, the aim of this PR is to add a new setting called "ref_axis_pos" (stands for reference axis position) that is generalizing the "chord_scaling_pos" for every geometric transformation that needed it : twist (rotate), span (stretch), taper, chord (scaleX). Setting the ref_axis_pos, the user can decide around with reference line the geometric variable will be applied, ref_axis_pos = 0.25 is the quarter of chord and was the default one. ref_axis_pos = 1 is around the trailing edge, ref_axis_pos = 0 is around leading edge.
Expected time until merged
a week
Type of change
Testing
Verified that the geometric variable have the correct behavior on simple cases (opt_chord.py, opt_twist.py)
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable