Increased ANKSwitchTol #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewu63
reviewed
May 9, 2022
| @@ -124,6 +124,9 @@ def test_solve(self): | |||
|
|
|||
|
|
|||
| class TestFailedMesh(unittest.TestCase): | |||
|
|
|||
| N_PROCS = 1 | |||
There was a problem hiding this comment.
Just FYI that this is already the default in testflo, but I guess this is more explicit.
There was a problem hiding this comment.
I think N_PROCS = 1 will run with MPI but with one processor. The test in the terminal has (mpi) before the path and no other terminal output is printed. I made this change to avoid having the ADflow header printed out during the tests.
ewu63
approved these changes
May 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #218 +/- ##
=======================================
Coverage 40.62% 40.62%
=======================================
Files 13 13
Lines 3769 3769
=======================================
Hits 1531 1531
Misses 2238 2238
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
marcomangano
approved these changes
May 9, 2022
ArshSaja
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As discussed in the maintenance meeting, I increased
ANKSwitchTolsuch that we are practically guaranteed to start with ANK for all cases. A switch tolerance of 1.0 will still use the smoothers when design changes increase the residual above the reference, or even on the first call in some cases as @nwu63 found (probably due to floating point precision).Expected time until merged
1-2 days
Type of change
Testing
Checklist
flake8andblackto make sure the code adheres to PEP-8 and is consistently formatted