Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When you call
getSolution
with multiple families the values calculated by the earlier families are zeroed on the last iteration.I don't believe this was ever the intended behavior and frankly I'm surprised this was left on unfixed for so long.
When using
evalFunctions
'getSolution` is called individually for each group which is why this isn't currently messing up everyone's casesExpected time until merged
1 week
Type of change
Testing
Ask @lambe for his test script if you'd like
Checklist
flake8
andblack
to make sure the code adheres to PEP-8 and is consistently formatted