-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating stdout for output files written #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Could you post a screenshot of the updated stdout if you have it handy?
Converting to draft for now. Will provide more detail later. |
Codecov Report
@@ Coverage Diff @@
## main #257 +/- ##
=======================================
Coverage 40.77% 40.77%
=======================================
Files 13 13
Lines 3882 3882
=======================================
Hits 1583 1583
Misses 2299 2299 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Just to clarify, this one is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The printing looks clean!
Purpose
As described in #237, filenames for different output files are not consistently written out. This PR addresses these issues. Additionally, time-accurate and time-spectral files should now also be written consistently to stdout.
Closes #237
Expected output for steady cases
Expected output for one time-step
Expected time until merged
No rush
Type of change
Testing
Please test different problems and combinations to make sure it works as expected.
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable