Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating stdout for output files written #257

Merged
merged 10 commits into from
Feb 21, 2023
Merged

Conversation

eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Jan 23, 2023

Purpose

As described in #237, filenames for different output files are not consistently written out. This PR addresses these issues. Additionally, time-accurate and time-spectral files should now also be written consistently to stdout.

Closes #237

Expected output for steady cases

#
# Writing grid file(s):
#    outdir/wing_000_vol.cgns
# Grid file(s) written
#
#
# Writing volume solution file(s):
#    outdir/wing_000_vol.cgns
# Volume solution file(s) written
#
#
# Writing surface solution file(s):
#    outdir/wing_000_surf.cgns
# Surface solution file(s) written
#
#
# Writing slices file(s): 
#    outdir/wing_000_slices.dat
# Slices file(s) written
#
#
# Writing lift distribution file(s):
#    outdir/wing_000_lift.dat
# Lift distribution file(s) written
#
#
# Writing tecplot surface file(s):
#    outdir/wing_000_surf.plt
# Tecplot surface file(s) written

Expected output for one time-step

# Writing grid file(s):
#    outdir/wing_000_vol.cgnsTimestep2
#    outdir/wing_000_vol.cgnsTimestep1
# Grid file(s) written
#
#
# Writing volume solution file(s):
#    outdir/wing_000_vol.cgnsTimestep2
#    outdir/wing_000_vol.cgnsTimestep1
# Volume solution file(s) written
#
#
# Writing surface solution file(s):
#    outdir/wing_000_surf.cgnsTimestep0002
# Surface solution file(s) written
#
#
# Writing slices file(s): 
#    outdir/wing_000_slices_Timestep0002.dat
# Slices file(s) written
#
#
# Writing lift distribution file(s):
#    outdir/wing_000_lift_Timestep0002.dat
# Lift distribution file(s) written
#
#
# Writing tecplot surface file(s):
#    outdir/wing_000_surf_Timestep0002.plt
# Tecplot surface file(s) written
#

Expected time until merged

No rush

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Please test different problems and combinations to make sure it works as expected.

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner January 23, 2023 15:37
Copy link
Contributor

@marcomangano marcomangano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Could you post a screenshot of the updated stdout if you have it handy?

src/output/tecplotIO.F90 Outdated Show resolved Hide resolved
@eirikurj eirikurj marked this pull request as draft January 23, 2023 15:56
@eirikurj
Copy link
Contributor Author

Converting to draft for now. Will provide more detail later.

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #257 (8f1f91c) into main (33fb96d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   40.77%   40.77%           
=======================================
  Files          13       13           
  Lines        3882     3882           
=======================================
  Hits         1583     1583           
  Misses       2299     2299           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eirikurj eirikurj marked this pull request as ready for review January 23, 2023 16:58
@eirikurj
Copy link
Contributor Author

Just to clarify, this one is ready for review

marcomangano
marcomangano previously approved these changes Feb 20, 2023
Copy link
Contributor

@ArshSaja ArshSaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The printing looks clean!

@ArshSaja ArshSaja merged commit 770e098 into main Feb 21, 2023
@marcomangano marcomangano deleted the addStdoutWritingFiles branch February 21, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Print out names of all written files
3 participants