Fixed f2py string intent

[sseraj]

Purpose

numpy 1.22 introduced some changes to how array dimensions are determined with f2py. From what I can tell, intent(out) strings of undetermined length are no longer valid (or have never been valid but did not previously raise an error).

ADflow has 4 string variables with intent(inout) that cause problems with numpy 1.22. I posted the error message in #256. However, we never use these variables in Python after passing them to Fortran, so I changed them to intent(in). This fixes the error and does not change the behavior of the code.

Expected time until merged

1 week

Type of change

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (non-backwards-compatible fix or feature)
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Documentation update
• Maintenance update
• Other (please describe)

Testing

I installed numpy 1.22, recompiled ADflow with these changes, and checked that all tests pass.

Checklist

• I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
• I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
• I have run unit and regression tests which pass locally with my changes
• I have added new tests that prove my fix is effective or that my feature works
• I have added necessary documentation

[marcomangano]

This looks good, nice catch. I guess the only way to test this would be to bump numpy version on latest images?

[sseraj]

Yes, we can't test this on Azure without updating the Docker images. I tested this locally using a Docker image, so you can try that to verify the fix.

[codecov]

Codecov Report

Merging #262 (69b0ada) into main (c750279) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   40.77%   40.77%           
=======================================
  Files          13       13           
  Lines        3882     3882           
=======================================
  Hits         1583     1583           
  Misses       2299     2299           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[joanibal]

Nice