adjust tolerances on single test for arm builds #286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A dot product in a single functionals test was not meeting the 1e-10 relative tolerance target; it was getting a relative error of around 1.6e-10. Because this is a dot product test, we cannot change any convergence tolerance, and I did not want to re-train a new test with a slightly different state, which would likely pass this test.
So I just added a slightly higher tolerance 2e-10 for this one particular case. The other parametrized test instances still maintain a tolerance of 1e-10.
Expected time until merged
2 days
Type of change
Testing
Checklist
flake8
andblack
to make sure the Python code adheres to PEP-8 and is consistently formattedfprettify
or C/C++ code withclang-format
as applicable