Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust tolerances on single test for arm builds #286

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

anilyil
Copy link
Contributor

@anilyil anilyil commented Jun 5, 2023

Purpose

A dot product in a single functionals test was not meeting the 1e-10 relative tolerance target; it was getting a relative error of around 1.6e-10. Because this is a dot product test, we cannot change any convergence tolerance, and I did not want to re-train a new test with a slightly different state, which would likely pass this test.

So I just added a slightly higher tolerance 2e-10 for this one particular case. The other parametrized test instances still maintain a tolerance of 1e-10.

Expected time until merged

2 days

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@anilyil anilyil requested a review from a team as a code owner June 5, 2023 16:46
@anilyil anilyil requested review from eirikurj, marcomangano and sseraj and removed request for marcomangano June 5, 2023 16:46
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #286 (6e82106) into main (f9d093d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   42.51%   42.51%           
=======================================
  Files          13       13           
  Lines        3952     3952           
=======================================
  Hits         1680     1680           
  Misses       2272     2272           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@anilyil anilyil merged commit f8943e6 into mdolab:main Jun 5, 2023
@anilyil anilyil deleted the adjust_tol branch June 5, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants