Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CGNS 4.4 #315

Merged
merged 3 commits into from
Sep 9, 2023
Merged

Update to CGNS 4.4 #315

merged 3 commits into from
Sep 9, 2023

Conversation

eirikurj
Copy link
Contributor

@eirikurj eirikurj commented Sep 7, 2023

Purpose

The CGNS library removed legacy constants. This change is backwards compatible with the CGNS version we currently support.

Expected time until merged

No rush

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eirikurj eirikurj requested a review from a team as a code owner September 7, 2023 09:22
@eirikurj eirikurj requested review from sseraj and ArshSaja September 7, 2023 09:22
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #315 (8ec7b00) into main (f162cfb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   41.98%   41.98%           
=======================================
  Files          13       13           
  Lines        4001     4001           
=======================================
  Hits         1680     1680           
  Misses       2321     2321           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@anilyil anilyil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gang525 did we merge the antisymmetry changes? If not, this PR might create conflicts. Can you please update the latest antisymmetry branch with similar changes and merge mdolab/main after we merge this?

@anilyil anilyil merged commit 686d096 into main Sep 9, 2023
@anilyil anilyil deleted the updateCGNS branch September 9, 2023 23:03
eirikurj added a commit to eirikurj/adflow that referenced this pull request Nov 4, 2023
* update to cgns 4.4

* remove unused semicolons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants