Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed string formatting styles #347

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Conversation

eytanadler
Copy link
Contributor

@eytanadler eytanadler commented Mar 7, 2024

Purpose

PR #345 added a new feature but combined string formatting styles. This PR changes it to consistently be f strings.

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@eytanadler eytanadler requested review from eirikurj and sseraj March 7, 2024 17:04
@eytanadler eytanadler requested a review from a team as a code owner March 7, 2024 17:04
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 41.47%. Comparing base (5a8c177) to head (b3ef06f).

Files Patch % Lines
adflow/pyADflow.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage   41.47%   41.47%           
=======================================
  Files          13       13           
  Lines        4068     4068           
=======================================
  Hits         1687     1687           
  Misses       2381     2381           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sseraj sseraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that this still works and added the test

@eirikurj eirikurj merged commit 572f2bf into mdolab:main Mar 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants