Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icc check #356

Merged
merged 2 commits into from
May 16, 2024
Merged

Fix icc check #356

merged 2 commits into from
May 16, 2024

Conversation

A-CGray
Copy link
Member

@A-CGray A-CGray commented May 15, 2024

Purpose

Inline comment messes with the ifdef check, see mdolab/pyhyp#87 (comment) for details

Expected time until merged

Type of change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Testing

Checklist

  • I have run flake8 and black to make sure the Python code adheres to PEP-8 and is consistently formatted
  • I have formatted the Fortran code with fprettify or C/C++ code with clang-format as applicable
  • I have run unit and regression tests which pass locally with my changes
  • I have added new tests that prove my fix is effective or that my feature works
  • I have added necessary documentation

@A-CGray A-CGray requested a review from a team as a code owner May 15, 2024 22:22
@A-CGray A-CGray requested review from sseraj and ArshSaja May 15, 2024 22:22
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.45%. Comparing base (4a0f01c) to head (96b3f37).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #356   +/-   ##
=======================================
  Coverage   41.45%   41.45%           
=======================================
  Files          13       13           
  Lines        4069     4069           
=======================================
  Hits         1687     1687           
  Misses       2382     2382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArshSaja ArshSaja merged commit 8d3d035 into main May 16, 2024
17 checks passed
@marcomangano marcomangano deleted the intelFixAgain branch May 16, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants