Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub profile #145

Merged
merged 8 commits into from
Oct 23, 2020
Merged

Add GitHub profile #145

merged 8 commits into from
Oct 23, 2020

Conversation

joelazwar
Copy link
Contributor

Feature request #108 Adds display template for github profiles

Copy link
Owner

@mdolr mdolr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, great pull request, could you just :

  • Make the picture rounded (border-radius:50%)
  • Display links below the repo / followers / following count
  • Replace icon by text (e.g: "Twitter:", "Workplace:" (we will decide on an icon set later)

@joelazwar
Copy link
Contributor Author

@mdolr I made the changes as you requested and a few others

  • Profile picture is now round
  • Links are displayed below the repo/follower/following count, and i've aligned the counts to be centered as per container
  • Replaced the icons for links with text for now, added some styling edits as well (e.g for unavailable links)

@mdolr
Copy link
Owner

mdolr commented Oct 23, 2020

Merged 👍

@mdolr mdolr merged commit 5c7a6dc into mdolr:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants