Added -target-release flag to control which component to bump if pre-release #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible values are
patch(default),minorandmajor.Closes #29
details
I created the custom enum-like type
TargetReleaseto hold values for the new flag. I gave it the Value interface (methodsStringandSet) so that the flags package can deal with this type on its own.The
Stringmethod forTargetReleasepanics if the integer value is not one of the enums. I don't know if it is good practice to do that (i am a golang beginner), I just felt there was no other way to deal with this case.Using
patchas default value preserves the previous behavior so that there should be no regression.