Add BIC registries #111
Merged
Add BIC registries #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mdomke, thanks for the great repo, I'd like to add a few bic entries here if that's ok with you. |
|
Hi @taoisu, thank you for your contribution, and sorry for the late reply. Would it be possible that you also add the scripts that you used to generate the registry files? That would allow me to update the data from time to time. |
|
@taoisu would you be able to add the scripts alongside the generated registry entries? That would be helpful! |
|
@taoisu never mind, I found the script in your commit history 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running a script to call 3rd party apis to get the registries for missing countries.
The script is excluded from this pr, if needed I can check-in as a separate pr.